Skip to content

Commit a2e3ead

Browse files
alexander-akaitalexander-akait
authored
fix: avoid duplicate App updated. Recompiling... (#3488)
1 parent 5ecbd77 commit a2e3ead

File tree

3 files changed

+2
-37
lines changed

3 files changed

+2
-37
lines changed

‎lib/Server.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -228,11 +228,8 @@ class Server {
228228
};
229229

230230
const addHooks = (compiler) => {
231-
const { compile, invalid, done } = compiler.hooks;
232-
233-
compile.tap('webpack-dev-server', invalidPlugin);
234-
invalid.tap('webpack-dev-server', invalidPlugin);
235-
done.tap('webpack-dev-server', (stats) => {
231+
compiler.hooks.invalid.tap('webpack-dev-server', invalidPlugin);
232+
compiler.hooks.done.tap('webpack-dev-server', (stats) => {
236233
this.sendStats(this.webSocketConnections, this.getStats(stats));
237234
this.stats = stats;
238235
});

‎test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack4

-16
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ Array [
1818
"[webpack-dev-server] Hot Module Replacement enabled.",
1919
"[webpack-dev-server] Live Reloading enabled.",
2020
"[webpack-dev-server] App updated. Recompiling...",
21-
"[webpack-dev-server] App updated. Recompiling...",
2221
"[webpack-dev-server] App hot update...",
2322
"[HMR] Checking for updates on the server...",
2423
"[HMR] Updated modules:",
@@ -37,7 +36,6 @@ Array [
3736
"[webpack-dev-server] Hot Module Replacement enabled.",
3837
"[webpack-dev-server] Live Reloading enabled.",
3938
"[webpack-dev-server] App updated. Recompiling...",
40-
"[webpack-dev-server] App updated. Recompiling...",
4139
"[webpack-dev-server] App hot update...",
4240
"[HMR] Checking for updates on the server...",
4341
"[HMR] Updated modules:",
@@ -56,7 +54,6 @@ Array [
5654
"[webpack-dev-server] Hot Module Replacement enabled.",
5755
"[webpack-dev-server] Live Reloading enabled.",
5856
"[webpack-dev-server] App updated. Recompiling...",
59-
"[webpack-dev-server] App updated. Recompiling...",
6057
"[webpack-dev-server] App hot update...",
6158
"[HMR] Checking for updates on the server...",
6259
"[HMR] Updated modules:",
@@ -75,7 +72,6 @@ Array [
7572
"[webpack-dev-server] Hot Module Replacement enabled.",
7673
"[webpack-dev-server] Live Reloading enabled.",
7774
"[webpack-dev-server] App updated. Recompiling...",
78-
"[webpack-dev-server] App updated. Recompiling...",
7975
"[webpack-dev-server] App hot update...",
8076
"[HMR] Checking for updates on the server...",
8177
"[HMR] Updated modules:",
@@ -94,7 +90,6 @@ Array [
9490
"[webpack-dev-server] Hot Module Replacement enabled.",
9591
"[webpack-dev-server] Live Reloading enabled.",
9692
"[webpack-dev-server] App updated. Recompiling...",
97-
"[webpack-dev-server] App updated. Recompiling...",
9893
"[webpack-dev-server] App hot update...",
9994
"[HMR] Checking for updates on the server...",
10095
"[HMR] Updated modules:",
@@ -113,7 +108,6 @@ Array [
113108
"[webpack-dev-server] Hot Module Replacement enabled.",
114109
"[webpack-dev-server] Live Reloading enabled.",
115110
"[webpack-dev-server] App updated. Recompiling...",
116-
"[webpack-dev-server] App updated. Recompiling...",
117111
"[webpack-dev-server] App hot update...",
118112
"[HMR] Checking for updates on the server...",
119113
"[HMR] Updated modules:",
@@ -131,7 +125,6 @@ Array [
131125
"[HMR] Waiting for update signal from WDS...",
132126
"[webpack-dev-server] Hot Module Replacement enabled.",
133127
"[webpack-dev-server] App updated. Recompiling...",
134-
"[webpack-dev-server] App updated. Recompiling...",
135128
"[webpack-dev-server] App hot update...",
136129
"[HMR] Checking for updates on the server...",
137130
"[HMR] Updated modules:",
@@ -149,7 +142,6 @@ Array [
149142
"[HMR] Waiting for update signal from WDS...",
150143
"[webpack-dev-server] Hot Module Replacement enabled.",
151144
"[webpack-dev-server] App updated. Recompiling...",
152-
"[webpack-dev-server] App updated. Recompiling...",
153145
"[webpack-dev-server] App hot update...",
154146
"[HMR] Checking for updates on the server...",
155147
"[HMR] Updated modules:",
@@ -167,7 +159,6 @@ Array [
167159
"[HMR] Waiting for update signal from WDS...",
168160
"[webpack-dev-server] Hot Module Replacement enabled.",
169161
"[webpack-dev-server] App updated. Recompiling...",
170-
"[webpack-dev-server] App updated. Recompiling...",
171162
"[webpack-dev-server] App hot update...",
172163
"[HMR] Checking for updates on the server...",
173164
"[HMR] Updated modules:",
@@ -186,7 +177,6 @@ Array [
186177
"[webpack-dev-server] Hot Module Replacement enabled.",
187178
"[webpack-dev-server] Live Reloading enabled.",
188179
"[webpack-dev-server] App updated. Recompiling...",
189-
"[webpack-dev-server] App updated. Recompiling...",
190180
"[webpack-dev-server] App hot update...",
191181
"[HMR] Checking for updates on the server...",
192182
"[HMR] Updated modules:",
@@ -205,7 +195,6 @@ Array [
205195
"[webpack-dev-server] Hot Module Replacement enabled.",
206196
"[webpack-dev-server] Live Reloading enabled.",
207197
"[webpack-dev-server] App updated. Recompiling...",
208-
"[webpack-dev-server] App updated. Recompiling...",
209198
"[webpack-dev-server] App hot update...",
210199
"[HMR] Checking for updates on the server...",
211200
"[HMR] Updated modules:",
@@ -224,7 +213,6 @@ Array [
224213
"[webpack-dev-server] Hot Module Replacement enabled.",
225214
"[webpack-dev-server] Live Reloading enabled.",
226215
"[webpack-dev-server] App updated. Recompiling...",
227-
"[webpack-dev-server] App updated. Recompiling...",
228216
"[webpack-dev-server] App hot update...",
229217
"[HMR] Checking for updates on the server...",
230218
"[HMR] Updated modules:",
@@ -243,7 +231,6 @@ Array [
243231
"[webpack-dev-server] Hot Module Replacement enabled.",
244232
"[webpack-dev-server] Live Reloading enabled.",
245233
"[webpack-dev-server] App updated. Recompiling...",
246-
"[webpack-dev-server] App updated. Recompiling...",
247234
"[webpack-dev-server] App hot update...",
248235
"[HMR] Checking for updates on the server...",
249236
"[HMR] Updated modules:",
@@ -260,7 +247,6 @@ exports[`hot and live reload should work and refresh content using live reload (
260247
Array [
261248
"[webpack-dev-server] Live Reloading enabled.",
262249
"[webpack-dev-server] App updated. Recompiling...",
263-
"[webpack-dev-server] App updated. Recompiling...",
264250
"[webpack-dev-server] App updated. Reloading...",
265251
"[webpack-dev-server] Live Reloading enabled.",
266252
]
@@ -272,7 +258,6 @@ exports[`hot and live reload should work and refresh content using live reload w
272258
Array [
273259
"[webpack-dev-server] Live Reloading enabled.",
274260
"[webpack-dev-server] App updated. Recompiling...",
275-
"[webpack-dev-server] App updated. Recompiling...",
276261
"[webpack-dev-server] App updated. Reloading...",
277262
"[webpack-dev-server] Live Reloading enabled.",
278263
]
@@ -284,7 +269,6 @@ exports[`hot and live reload should work and refresh content using live reload w
284269
Array [
285270
"[webpack-dev-server] Live Reloading enabled.",
286271
"[webpack-dev-server] App updated. Recompiling...",
287-
"[webpack-dev-server] App updated. Recompiling...",
288272
"[webpack-dev-server] App updated. Reloading...",
289273
"[webpack-dev-server] Live Reloading enabled.",
290274
]

‎test/e2e/__snapshots__/hot-and-live-reload.test.js.snap.webpack5

-16
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ Array [
1818
"[webpack-dev-server] Hot Module Replacement enabled.",
1919
"[webpack-dev-server] Live Reloading enabled.",
2020
"[webpack-dev-server] App updated. Recompiling...",
21-
"[webpack-dev-server] App updated. Recompiling...",
2221
"[webpack-dev-server] App hot update...",
2322
"[HMR] Checking for updates on the server...",
2423
"[HMR] Updated modules:",
@@ -37,7 +36,6 @@ Array [
3736
"[webpack-dev-server] Hot Module Replacement enabled.",
3837
"[webpack-dev-server] Live Reloading enabled.",
3938
"[webpack-dev-server] App updated. Recompiling...",
40-
"[webpack-dev-server] App updated. Recompiling...",
4139
"[webpack-dev-server] App hot update...",
4240
"[HMR] Checking for updates on the server...",
4341
"[HMR] Updated modules:",
@@ -56,7 +54,6 @@ Array [
5654
"[webpack-dev-server] Hot Module Replacement enabled.",
5755
"[webpack-dev-server] Live Reloading enabled.",
5856
"[webpack-dev-server] App updated. Recompiling...",
59-
"[webpack-dev-server] App updated. Recompiling...",
6057
"[webpack-dev-server] App hot update...",
6158
"[HMR] Checking for updates on the server...",
6259
"[HMR] Updated modules:",
@@ -75,7 +72,6 @@ Array [
7572
"[webpack-dev-server] Hot Module Replacement enabled.",
7673
"[webpack-dev-server] Live Reloading enabled.",
7774
"[webpack-dev-server] App updated. Recompiling...",
78-
"[webpack-dev-server] App updated. Recompiling...",
7975
"[webpack-dev-server] App hot update...",
8076
"[HMR] Checking for updates on the server...",
8177
"[HMR] Updated modules:",
@@ -94,7 +90,6 @@ Array [
9490
"[webpack-dev-server] Hot Module Replacement enabled.",
9591
"[webpack-dev-server] Live Reloading enabled.",
9692
"[webpack-dev-server] App updated. Recompiling...",
97-
"[webpack-dev-server] App updated. Recompiling...",
9893
"[webpack-dev-server] App hot update...",
9994
"[HMR] Checking for updates on the server...",
10095
"[HMR] Updated modules:",
@@ -113,7 +108,6 @@ Array [
113108
"[webpack-dev-server] Hot Module Replacement enabled.",
114109
"[webpack-dev-server] Live Reloading enabled.",
115110
"[webpack-dev-server] App updated. Recompiling...",
116-
"[webpack-dev-server] App updated. Recompiling...",
117111
"[webpack-dev-server] App hot update...",
118112
"[HMR] Checking for updates on the server...",
119113
"[HMR] Updated modules:",
@@ -131,7 +125,6 @@ Array [
131125
"[HMR] Waiting for update signal from WDS...",
132126
"[webpack-dev-server] Hot Module Replacement enabled.",
133127
"[webpack-dev-server] App updated. Recompiling...",
134-
"[webpack-dev-server] App updated. Recompiling...",
135128
"[webpack-dev-server] App hot update...",
136129
"[HMR] Checking for updates on the server...",
137130
"[HMR] Updated modules:",
@@ -149,7 +142,6 @@ Array [
149142
"[HMR] Waiting for update signal from WDS...",
150143
"[webpack-dev-server] Hot Module Replacement enabled.",
151144
"[webpack-dev-server] App updated. Recompiling...",
152-
"[webpack-dev-server] App updated. Recompiling...",
153145
"[webpack-dev-server] App hot update...",
154146
"[HMR] Checking for updates on the server...",
155147
"[HMR] Updated modules:",
@@ -167,7 +159,6 @@ Array [
167159
"[HMR] Waiting for update signal from WDS...",
168160
"[webpack-dev-server] Hot Module Replacement enabled.",
169161
"[webpack-dev-server] App updated. Recompiling...",
170-
"[webpack-dev-server] App updated. Recompiling...",
171162
"[webpack-dev-server] App hot update...",
172163
"[HMR] Checking for updates on the server...",
173164
"[HMR] Updated modules:",
@@ -186,7 +177,6 @@ Array [
186177
"[webpack-dev-server] Hot Module Replacement enabled.",
187178
"[webpack-dev-server] Live Reloading enabled.",
188179
"[webpack-dev-server] App updated. Recompiling...",
189-
"[webpack-dev-server] App updated. Recompiling...",
190180
"[webpack-dev-server] App hot update...",
191181
"[HMR] Checking for updates on the server...",
192182
"[HMR] Updated modules:",
@@ -205,7 +195,6 @@ Array [
205195
"[webpack-dev-server] Hot Module Replacement enabled.",
206196
"[webpack-dev-server] Live Reloading enabled.",
207197
"[webpack-dev-server] App updated. Recompiling...",
208-
"[webpack-dev-server] App updated. Recompiling...",
209198
"[webpack-dev-server] App hot update...",
210199
"[HMR] Checking for updates on the server...",
211200
"[HMR] Updated modules:",
@@ -224,7 +213,6 @@ Array [
224213
"[webpack-dev-server] Hot Module Replacement enabled.",
225214
"[webpack-dev-server] Live Reloading enabled.",
226215
"[webpack-dev-server] App updated. Recompiling...",
227-
"[webpack-dev-server] App updated. Recompiling...",
228216
"[webpack-dev-server] App hot update...",
229217
"[HMR] Checking for updates on the server...",
230218
"[HMR] Updated modules:",
@@ -243,7 +231,6 @@ Array [
243231
"[webpack-dev-server] Hot Module Replacement enabled.",
244232
"[webpack-dev-server] Live Reloading enabled.",
245233
"[webpack-dev-server] App updated. Recompiling...",
246-
"[webpack-dev-server] App updated. Recompiling...",
247234
"[webpack-dev-server] App hot update...",
248235
"[HMR] Checking for updates on the server...",
249236
"[HMR] Updated modules:",
@@ -260,7 +247,6 @@ exports[`hot and live reload should work and refresh content using live reload (
260247
Array [
261248
"[webpack-dev-server] Live Reloading enabled.",
262249
"[webpack-dev-server] App updated. Recompiling...",
263-
"[webpack-dev-server] App updated. Recompiling...",
264250
"[webpack-dev-server] App updated. Reloading...",
265251
"[webpack-dev-server] Live Reloading enabled.",
266252
]
@@ -272,7 +258,6 @@ exports[`hot and live reload should work and refresh content using live reload w
272258
Array [
273259
"[webpack-dev-server] Live Reloading enabled.",
274260
"[webpack-dev-server] App updated. Recompiling...",
275-
"[webpack-dev-server] App updated. Recompiling...",
276261
"[webpack-dev-server] App updated. Reloading...",
277262
"[webpack-dev-server] Live Reloading enabled.",
278263
]
@@ -284,7 +269,6 @@ exports[`hot and live reload should work and refresh content using live reload w
284269
Array [
285270
"[webpack-dev-server] Live Reloading enabled.",
286271
"[webpack-dev-server] App updated. Recompiling...",
287-
"[webpack-dev-server] App updated. Recompiling...",
288272
"[webpack-dev-server] App updated. Reloading...",
289273
"[webpack-dev-server] Live Reloading enabled.",
290274
]

0 commit comments

Comments
 (0)