Skip to content

fix: get rid of Symbol core-js polyfill #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2021
Merged

fix: get rid of Symbol core-js polyfill #3535

merged 1 commit into from
Jul 19, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jul 19, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Tested manually

Motivation / Use-Case

Avoid Symbol use when they are not supported

Breaking Changes

No

Additional Info

fixed #3502

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #3535 (1e6b1e1) into master (f62f20f) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3535      +/-   ##
==========================================
- Coverage   94.43%   94.27%   -0.16%     
==========================================
  Files          20       20              
  Lines        1294     1293       -1     
  Branches      430      430              
==========================================
- Hits         1222     1219       -3     
- Misses         67       69       +2     
  Partials        5        5              
Impacted Files Coverage Δ
client-src/modules/logger/index.js 100.00% <ø> (ø)
lib/servers/WebsocketServer.js 91.66% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62f20f...1e6b1e1. Read the comment docs.

@alexander-akait alexander-akait merged commit 7afe3d2 into master Jul 19, 2021
@alexander-akait alexander-akait deleted the issue-3502 branch July 19, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of core-js polyfill added in 4.0.0.beta-2
1 participant