Skip to content

Commit d1f5881

Browse files
rscwheatman
authored andcommitted
os: skip TestRemoveAllRace on Windows
It's just fundamentally incompatible with Windows' pickiness about removing things that are in use. TBR=brainman CC=golang-codereviews https://golang.org/cl/142270043
1 parent 50e5ac9 commit d1f5881

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/os/os_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1439,6 +1439,14 @@ func mkdirTree(t *testing.T, root string, level, max int) {
14391439
// Test that simultaneous RemoveAll do not report an error.
14401440
// As long as it gets removed, we should be happy.
14411441
func TestRemoveAllRace(t *testing.T) {
1442+
if runtime.GOOS == "windows" {
1443+
// Windows has very strict rules about things like
1444+
// removing directories while someone else has
1445+
// them open. The racing doesn't work out nicely
1446+
// like it does on Unix.
1447+
t.Skip("skipping on windows")
1448+
}
1449+
14421450
n := runtime.GOMAXPROCS(16)
14431451
defer runtime.GOMAXPROCS(n)
14441452
root, err := ioutil.TempDir("", "issue")

0 commit comments

Comments
 (0)