Skip to content
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Fix peer dependencies for TS 3 #373

Open
2 tasks done
nickserv opened this issue Jul 30, 2018 · 7 comments
Open
2 tasks done

Fix peer dependencies for TS 3 #373

nickserv opened this issue Jul 30, 2018 · 7 comments

Comments

@nickserv
Copy link

nickserv commented Jul 30, 2018 •
edited
Loading

TypeScript 3 has been released, and has a small enough number of breaking changes that it shouldn't be too hard for us to officially support. I upgraded to 3.0.1 and it does seem to work well in CRA-TS, but we should probably verify that our dependencies have official TS 3 support.

npm WARN [email protected] requires a peer of typescript@^2.1.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.

Related
@DorianGrey DorianGrey mentioned this issue Jul 31, 2018
Closed
@DorianGrey
Copy link
Collaborator

Thanks for keeping track of these.
Seems that updating the plugin might take a while, given that the main author is not that active at the moment.

@nickserv
Copy link
Author

nickserv commented Aug 4, 2018

Both packages updated with TS 3 support, I'll publish a PR as soon as I have time to test the new version contraints.

@nickserv nickserv mentioned this issue Aug 5, 2018
Closed
@nickserv nickserv changed the title Fix peer dependency warnings for TS 3 Fix peer dependencies for TS 3 Sep 1, 2018
@nickserv nickserv mentioned this issue Sep 1, 2018
Closed
@nickserv
Copy link
Author

nickserv commented Sep 1, 2018

It seems like TS 3 is now in master, but there are still peer dependency warnings, see #387.

@Tracis
Copy link

Tracis commented Sep 10, 2018

How to fix these warnings? Can I just ignore them?

@nickserv
Copy link
Author

#387 fixes them. For now you should ignore them until it's merged.

@Tracis
Copy link

Tracis commented Sep 10, 2018

I manually upgraded react-scripts-ts, ts-jest, babel-jest, jest, fork-ts-checker-webpack-plugin, ajv and solved these problems.

@franklixuefei
Copy link

how's this been going?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nickserv @franklixuefei @DorianGrey @Tracis