Skip to content

Commit 2eb1ef2

Browse files
committed
Address minor comments in dotnet#2243
1 parent 3eccc93 commit 2eb1ef2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/Microsoft.ML.FastTree/RegressionTree.cs

+3-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ public abstract class RegressionTreeBase
5656
/// Note that the case (1) happens only when <see cref="CategoricalSplitFlags"/>[i] is true and otherwise (2)
5757
/// occurs. A non-negative returned value means a node (i.e., not a leaf); for example, 2 means the 3rd node in
5858
/// the underlying <see cref="_tree"/>. A negative returned value means a leaf; for example, -1 stands for the
59-
/// first leaf in the underlying <see cref="_tree"/>.
59+
/// <see langword="~"/>(-1)-th leaf in the underlying <see cref="_tree"/>. Note that <see langword="~"/> is the
60+
/// bitwise complement operator in C#; for details, see
61+
/// https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/bitwise-complement-operator.
6062
/// </summary>
6163
public IReadOnlyList<int> LteChild => _lteChild;
6264

src/Microsoft.ML.FastTree/TreeEnsemble.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public abstract class TreeEnsemble<T> where T : RegressionTreeBase
2929
/// </summary>
3030
public IReadOnlyList<T> Trees { get; }
3131

32-
internal TreeEnsemble(IEnumerable<T> trees, IEnumerable<double> treeWeights, double bias)
32+
private protected TreeEnsemble(IEnumerable<T> trees, IEnumerable<double> treeWeights, double bias)
3333
{
3434
Bias = bias;
3535
TreeWeights = treeWeights.ToList();

0 commit comments

Comments
 (0)