-
Notifications
You must be signed in to change notification settings - Fork 0
Browserify compatibility #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This component is already compatible with browserify: require('angular-treemendous');
angular.module('app', ['treemendous']); There's no need to expose the name of the component as a string. What I can fix is the 'main' property of |
@paulpflug can you verify that the latest version (0.2.4) works for you as recommended above? If so, I'll close this issue. |
yeah works, the difference between the two is, the first one will be minified. I think it is the recommended version from browserify. but maybe thats not too important ;) |
I'm not sure how this difference would affect minification, but I have been taking a look around at other angular packages and it seems like this method is in wide use... it just feels weird to me to export a string, rather than the module itself. Something like: module.exports = angular.module('treemendous', ['ngAnimate']) var myApp = angular.module('myApp', [
require('angular-treemendous').name
]); But I'm still debating this... gonna do some research and then implement something better than what I have now. I also need to update dependencies and such - this project requires some general upkeep. |
I read about it at angular/angular.js#10732 For me it is very convincing ;) |
Oh, awesome - this is exactly the discussion I was looking for! Will update accordingly. |
would be wonderful ;)
just add a index.js
with
and set the main in package.json to index.js
I can make a pr if you want
The text was updated successfully, but these errors were encountered: