Address fast label renderer, changes in BoxView, and a bug in Android fast button

Author: hartez

Xamarin.Forms.ControlGallery.Android/Tests/PlatformTestFixture.cs

@@ -209,7 +209,15 @@ protected TextView GetNativeControl(Label label)
 		{
 			var renderer = GetRenderer(label);
 			var viewRenderer = renderer.View as LabelRenderer;
-			return viewRenderer.Control;
+
+			if (viewRenderer != null)
+			{
+				return viewRenderer.Control;
+			}
+
+			var fastRenderer = renderer.View as Platform.Android.FastRenderers.LabelRenderer;
+
+			return fastRenderer;
 		}
 
 		protected EditText GetNativeControl(Picker picker)

Xamarin.Forms.ControlGallery.WindowsUniversal/Tests/BackgroundColorTests.cs

@@ -3,6 +3,7 @@
 using NUnit.Framework;
 using Windows.UI.Xaml.Controls;
 using Windows.UI.Xaml.Media;
+using Windows.UI.Xaml.Shapes;
 using Xamarin.Forms.Platform.UWP;
 using WColor = Windows.UI.Color;
 
@@ -26,7 +27,7 @@ static IEnumerable TestCases
 			}
 		}
 
-		WColor GetBackgroundColor(Control control) 
+		WColor GetBackgroundColor(Control control)
 		{
 			if (control is FormsButton button)
 			{
@@ -41,21 +42,41 @@ WColor GetBackgroundColor(Control control)
 			return (control.Background as SolidColorBrush).Color;
 		}
 
-		WColor GetBackgroundColor(Panel panel) 
+		WColor GetBackgroundColor(Panel panel)
 		{
 			return (panel.Background as SolidColorBrush).Color;
 		}
 
-		[Test, TestCaseSource(nameof(TestCases))]
-		[Description("View background color should match renderer background color")]
-		public void BackgroundColorConsistent(View view)
+		WColor GetBackgroundColor(Border border)
+		{
+			return (border.Background as SolidColorBrush).Color;
+		}
+
+		WColor GetNativeColor(View view)
 		{
 			var control = GetNativeControl(view);
 
-			var nativeColor = control != null
-				? GetBackgroundColor(control)
-				: GetBackgroundColor(GetContainer(view));
+			if (control != null)
+			{
+				return GetBackgroundColor(control);
+			}
+
+			var border = GetBorder(view);
 
+			if (border != null)
+			{
+				return GetBackgroundColor(border);
+			}
+
+			var panel = GetPanel(view);
+			return GetBackgroundColor(panel);
+		}
+
+		[Test, TestCaseSource(nameof(TestCases))]
+		[Description("View background color should match renderer background color")]
+		public void BackgroundColorConsistent(View view)
+		{
+			var nativeColor = GetNativeColor(view);
 			var formsColor = view.BackgroundColor.ToUwpColor();
 			Assert.That(nativeColor, Is.EqualTo(formsColor));
 		}

Xamarin.Forms.ControlGallery.WindowsUniversal/Tests/PlatformTestFixture.cs

@@ -1,6 +1,7 @@
 using System.Collections.Generic;
 using NUnit.Framework;
 using Windows.UI.Xaml.Controls;
+using Windows.UI.Xaml.Shapes;
 using Xamarin.Forms.Platform.UWP;
 
 namespace Xamarin.Forms.ControlGallery.WindowsUniversal.Tests
@@ -51,10 +52,17 @@ protected Control GetNativeControl(VisualElement element)
 			return GetRenderer(element).GetNativeElement() as Control;
 		}
 
-		protected Panel GetContainer(VisualElement element) 
+		protected Panel GetPanel(VisualElement element) 
 		{
 			return GetRenderer(element).ContainerElement as Panel;
 		}
+
+		protected Border GetBorder(VisualElement element) 
+		{
+			var renderer = GetRenderer(element);
+			var nativeElement = renderer.GetNativeElement();
+			return nativeElement as Border;
+		}
 
 		protected TextBlock GetNativeControl(Label label)
 		{

Xamarin.Forms.Platform.Android/FastRenderers/ButtonRenderer.cs

@@ -104,7 +104,10 @@ SizeRequest IVisualElementRenderer.GetDesiredSize(int widthConstraint, int heigh
 
 			var result  = _buttonLayoutManager.GetDesiredSize(widthConstraint, heightConstraint);
 
-			Control.Hint = hint;
+			if (Control.Hint != hint)
+			{
+				Control.Hint = hint;
+			}
 
 			return result;
 		}