[crc64] Change the hash prefix back to crc64
#628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 9b88ce7 Context: 7fe3a11 7fe3a11 fixed the new CRC64 calculation algorithm so that it properly processes all the data, which had the (expected) effect of generating the same checksums for the same data as those generated before 9b88ce7 However, 7fe3a11 missed changing the new `c64r2` hash prefix back to `crc64`, thus this commit to make the change. The change will remove any backward incompatibility with code that may rely on the old hash format, including Xamarin.Android tests.
jonpryor
pushed a commit
that referenced
this pull request
Apr 22, 2020
Context: 9b88ce7 Context: 7fe3a11 7fe3a11 fixed the new CRC64 calculation algorithm so that it properly processes all the data, which had the (expected) effect of generating the same checksums for the same data as those generated before commit 9b88ce7. However, 7fe3a11 missed changing the new `c64r2` hash prefix back to `crc64`, thus this commit to make the change. The change will remove any backward incompatibility with code that may rely on the old hash format, including Xamarin.Android tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 9b88ce7
Context: 7fe3a11
7fe3a11 fixed the new CRC64 calculation algorithm so that it properly
processes all the data, which had the (expected) effect of generating
the same checksums for the same data as those generated before 9b88ce7
However, 7fe3a11 missed changing the new
c64r2hash prefix back tocrc64, thus this commit to make the change.The change will remove any backward incompatibility with code that may
rely on the old hash format, including Xamarin.Android tests.