[generator] Don't invalidate interface if we invalidate a static method on it. #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
that referenced
this pull request
Jun 11, 2020
#660) Fixes: #588 If we cannot bind a method on an interface we mark the interface as unbindable and omit the interface from the generated code, and invalidate anything that depends on the interface. This is because an interface with a missing method cannot be implemented in C#. However, if the method is `static` then we *can* remove the method while keeping the interface, as the user is not required to implement the static method. Update `GenBase.OnValidate()` so that invalid static methods don't invalidate their declaring interface. Note we already properly handled Default Interface Methods, this adds support for `static` methods as well.
|
Release Notes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #588
If we cannot bind a method on an interface we mark the interface as unbindable and omit the interface from the generated code (and anything that depends on it). This is because an interface with a missing method cannot be implemented in C#.
However if the method is
staticwe can remove the method but still keep the interface, as the user is not required to implement the static method. This PR makes this change to keep the interface.Note we already properly handled DIM, this adds support for
staticmethods as well.