[generator] Ensure non-constant static interface fields are generated as interface properties. #831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #821
Context: dotnet/android#5818
Context: #459
Context: #509
When we began generating static methods and properties on interfaces when running with DIM enabled, it looks like we did not include static fields that cannot be treated as constants.
Thus, given the following example from dotnet/android#5818:
we only generate:
This is an issue because we
[Obsolete]
'd the version in the *class*EGL10
pointing to the non-existentinterface
version:This commit generates the static interfaces fields as properties when
-lang-features=default-interface-methods
is specified.