Avoid entering into the more complex else branch

etienneschalk · etienneschalk · commit 2c0b3eaf7a55 · 2023-12-09T21:22:15.000+01:00
diff --git a/datatree/treenode.py b/datatree/treenode.py
@@ -634,7 +634,7 @@ def relative_to(self: NamedNode, other: NamedNode) -> str:
             )
 
         this_path = NodePath(self.path)
-        if other.path in list(parent.path for parent in self.parents):
+        if other.path in list(parent.path for parent in (self, *self.parents)):
             return str(this_path.relative_to(other.path))
         else:
             common_ancestor = self.find_common_ancestor(other)

Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,7 @@ def relative_to(self: NamedNode, other: NamedNode) -> str:`
`634`	`634`	`)`
`635`	`635`
`636`	`636`	`this_path = NodePath(self.path)`
`637`		`- if other.path in list(parent.path for parent in self.parents):`
	`637`	`+ if other.path in list(parent.path for parent in (self, *self.parents)):`
`638`	`638`	`return str(this_path.relative_to(other.path))`
`639`	`639`	`else:`
`640`	`640`	`common_ancestor = self.find_common_ancestor(other)`