From 5fabd1f720edbbe149946c3da9ce3af50de07695 Mon Sep 17 00:00:00 2001 From: loganthomas Date: Thu, 3 Nov 2022 21:58:53 -0500 Subject: [PATCH 1/6] add misc section to .gitignore to inlcude .DS_Store and .vscode/ --- .gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 51b6d60b..4cc41a3d 100644 --- a/.gitignore +++ b/.gitignore @@ -114,3 +114,7 @@ venv.bak/ # mypy .mypy_cache/ + +# misc +.DS_Store +.vscode/ From f966d361e11c2778faa790cb8f8028c970c99f41 Mon Sep 17 00:00:00 2001 From: loganthomas Date: Thu, 3 Nov 2022 22:00:13 -0500 Subject: [PATCH 2/6] fix typos in online-tutorial 01_xarray_fundamentals.ipynb --- .../01_xarray_fundamentals.ipynb | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/workshops/online-tutorial-series/01_xarray_fundamentals.ipynb b/workshops/online-tutorial-series/01_xarray_fundamentals.ipynb index 906afe8c..0ac062ce 100644 --- a/workshops/online-tutorial-series/01_xarray_fundamentals.ipynb +++ b/workshops/online-tutorial-series/01_xarray_fundamentals.ipynb @@ -32,7 +32,7 @@ " Implementing such functionality is left to individual users and\n", " domain-specific packages.\n", "\n", - "- xarry expands on the capabilities of NumPy arrays, providing a lot of\n", + "- xarray expands on the capabilities of NumPy arrays, providing a lot of\n", " streamline data manipulation.\n", "\n", "- Xarray's interface is based largely on the netCDF data model (variables,\n", @@ -236,7 +236,7 @@ "metadata": {}, "outputs": [], "source": [ - "# Extract the sst variable/datarray\n", + "# Extract the sst variable/data array\n", "ds[\"sst\"] # Equivalent to ds.sst" ] }, @@ -260,7 +260,7 @@ "metadata": {}, "outputs": [], "source": [ - "# dataarray/variable dimensions\n", + "# data array/variable dimensions\n", "ds.sst.dims" ] }, @@ -270,7 +270,7 @@ "metadata": {}, "outputs": [], "source": [ - "# datarray/variable coordinates\n", + "# data array/variable coordinates\n", "ds.sst.coords" ] }, @@ -280,7 +280,7 @@ "metadata": {}, "outputs": [], "source": [ - "# dataarray/variable attributes\n", + "# data array/variable attributes\n", "ds.sst.attrs" ] }, @@ -345,7 +345,7 @@ }, "outputs": [], "source": [ - "# extracting a coorindate variable from .coords\n", + "# extracting a coordinate variable from .coords\n", "ds.coords[\"time\"]" ] }, @@ -389,7 +389,7 @@ "metadata": {}, "outputs": [], "source": [ - "# Set some arbitrary attribute on a data variable/datarray\n", + "# Set some arbitrary attribute on a data variable/data array\n", "ds.sst.attrs[\"my_custom_attribute\"] = \"Foo Bar\"\n", "ds.sst.attrs" ] From 34afa0708696b1d5446f0fa54bfeab662aed2308 Mon Sep 17 00:00:00 2001 From: loganthomas Date: Thu, 3 Nov 2022 22:00:35 -0500 Subject: [PATCH 3/6] fix index mismatch in online-tutorial 02_indexing.ipynb --- workshops/online-tutorial-series/02_indexing.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workshops/online-tutorial-series/02_indexing.ipynb b/workshops/online-tutorial-series/02_indexing.ipynb index 19d2895b..8e7ffe79 100644 --- a/workshops/online-tutorial-series/02_indexing.ipynb +++ b/workshops/online-tutorial-series/02_indexing.ipynb @@ -103,7 +103,7 @@ "metadata": {}, "source": [ "
\n", - "but wait, what labels go with 10 and 20? Was that lat/lon or lon/lat? Where are the timestamps that go along with this time-series?\n", + "but wait, what labels go with 20 and 40? Was that lat/lon or lon/lat? Where are the timestamps that go along with this time-series?\n", "
\n" ] }, From 8ef9c4a3422ab427a9ec73f9435349ab7098b49e Mon Sep 17 00:00:00 2001 From: loganthomas Date: Thu, 3 Nov 2022 22:00:57 -0500 Subject: [PATCH 4/6] fix typos in online-tutorial 03_computation.ipynb --- workshops/online-tutorial-series/03_computation.ipynb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/workshops/online-tutorial-series/03_computation.ipynb b/workshops/online-tutorial-series/03_computation.ipynb index fac5a1ce..f4ae294e 100644 --- a/workshops/online-tutorial-series/03_computation.ipynb +++ b/workshops/online-tutorial-series/03_computation.ipynb @@ -98,8 +98,8 @@ "**Broadcasting** allows an operator or a function to act on two or more arrays\n", "to operate even if these arrays do not have the same shape. That said, not all\n", "the dimensions can be subjected to broadcasting; they must meet certain rules.\n", - "The image below t illustrates how performing an operation on arrays with\n", - "differenty coordinates will result in automatic broadcasting\n", + "The image below illustrates how performing an operation on arrays with\n", + "differently coordinates will result in automatic broadcasting\n", "\n", "![](../../images/broadcasting.png)\n", "\n", From 55a1709495f02cd92eded718e655f6ef158d9dc9 Mon Sep 17 00:00:00 2001 From: loganthomas Date: Thu, 3 Nov 2022 23:17:46 -0500 Subject: [PATCH 5/6] fix broken image link for pint in overview/xarray-in-45-min.ipynb --- overview/xarray-in-45-min.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/overview/xarray-in-45-min.ipynb b/overview/xarray-in-45-min.ipynb index b8a6dbbe..8054916c 100644 --- a/overview/xarray-in-45-min.ipynb +++ b/overview/xarray-in-45-min.ipynb @@ -925,7 +925,7 @@ "\n", " [GPU arrays](https://cupy.dev) & [cupy-xarray](https://cupy-xarray.readthedocs.io/)\n", "\n", - " **pint** : [unit-aware arrays](https://pint.readthedocs.io) & [pint-xarray](https://github.com/xarray-contrib/pint-xarray)\n" + " **pint** : [unit-aware arrays](https://pint.readthedocs.io) & [pint-xarray](https://github.com/xarray-contrib/pint-xarray)\n" ] }, { From 4b8d2dba986988cf1e4803f7498c99bc4bf65bd1 Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Fri, 4 Nov 2022 18:37:02 -0600 Subject: [PATCH 6/6] Apply suggestions from code review --- .../01_xarray_fundamentals.ipynb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/workshops/online-tutorial-series/01_xarray_fundamentals.ipynb b/workshops/online-tutorial-series/01_xarray_fundamentals.ipynb index 0ac062ce..03eded1c 100644 --- a/workshops/online-tutorial-series/01_xarray_fundamentals.ipynb +++ b/workshops/online-tutorial-series/01_xarray_fundamentals.ipynb @@ -236,7 +236,7 @@ "metadata": {}, "outputs": [], "source": [ - "# Extract the sst variable/data array\n", + "# Extract the sst Variable/DataArray\n", "ds[\"sst\"] # Equivalent to ds.sst" ] }, @@ -260,7 +260,7 @@ "metadata": {}, "outputs": [], "source": [ - "# data array/variable dimensions\n", + "# DataArray/Variable dimensions\n", "ds.sst.dims" ] }, @@ -270,7 +270,7 @@ "metadata": {}, "outputs": [], "source": [ - "# data array/variable coordinates\n", + "# DataArray/Variable coordinates\n", "ds.sst.coords" ] }, @@ -280,7 +280,7 @@ "metadata": {}, "outputs": [], "source": [ - "# data array/variable attributes\n", + "# DataArray/Variable attributes\n", "ds.sst.attrs" ] }, @@ -389,7 +389,7 @@ "metadata": {}, "outputs": [], "source": [ - "# Set some arbitrary attribute on a data variable/data array\n", + "# Set some arbitrary attribute on a data Variable/DataArray\n", "ds.sst.attrs[\"my_custom_attribute\"] = \"Foo Bar\"\n", "ds.sst.attrs" ]