Ooh yay! Thanks for the proposal. Sorry for the delay. I've been meaning to add transient for quite some time. I had a rough patch somewhere, but was for the compose buffer.

I've been contemplating either getting rid of some of these commands I see listed as they can be easily replaced by chatgpt-shell-quick-insert or maybe re-implemt using the same insertion mechanism.

One thing I'm wondering is how to deal with vanilla vs evil bindings. I'm not super familiar with evil, but j/k are vim bindings right? Do you know how other packages do it for their transient menus?

Ooh yay! Thanks for the proposal. Sorry for the delay. I've been meaning to add transient for quite some time. I had a rough patch somewhere, but was for the compose buffer.

No worries my dude! I can take this one, no problem 😁

I've been contemplating either getting rid of some of these commands I see listed as they can be easily replaced by chatgpt-shell-quick-insert or maybe re-implemt using the same insertion mechanism.

If you have a list of commands you want added to the menu, I can replace them 👍🏾

One thing I'm wondering is how to deal with vanilla vs evil bindings. I'm not super familiar with evil, but j/k are vim bindings right?

I use evil bindings, and this menu works perfectly fine!

Do you know how other packages do it for their transient menus?

I don't know, but I can investigate! There might be a vanilla version we can use. I have some time to put into this this weekend, once I have an update I'll let you know 👍🏾

A quick update, we might be able to get away with using define-prefix-command. I'll try converting my menu to define-prefix-command and see if it works 👍🏾

Nice! This looks like a good addition.

I've been meaning to add transient for quite some time. I had a rough patch somewhere, but was for the compose buffer.

Ok, here's the compose buffer one. It shows up automatically after LLM provider replies, unless chatgpt-shell-compose-auto-transient is unset. Menu organization, bindings, etc. aren't final.

That looks great! Sorry I haven’t been able to work on this lately, I’m on vacation overseas 😂

I’ll pick it back up next week when I’m back! But seriously, your menu looks way better than transient. Do you have a PR? Feel free to use mine as a base 👍🏾

No worries at all. There's no hurry here.

I’m on vacation overseas 😂

Hope you're somewhere nice enjoying yourself!

But seriously, your menu looks way better than transient.

It's transient too :) 2aa82cd

Oh, it's already merged! I remember I went with a vertical menu instead of horizontal because transient doesn’t play well with split window buffers. That’s why magit and aider do the same thing too. I'll update chatgpt-shell and test! 🔥

And it's no worry haha, I'm on vacation but still working today 😂

Oh, it's already merged!

This transient menu is for the compose buffer only. We still need your menu for the other buffers.

I went with a vertical menu instead of horizontal because transient doesn’t play well with split window buffers.

Good point. Let's see how well it works in practice. Happy to move to a more vertical approach if needed.

I'm on vacation but still working today 😂

😭

Hey @xenodium! This is how it looks like in split mode:

I guess vertical is the way to go then?

I guess vertical is the way to go then?

Sounds like it. So a 2 column width max?

ps. The transient I submitted was mostly thinking in the context of compose buffers. Some of the functions are unlikely to work on the shell.

In my example, I was able to squeeze in a bit more short columns:

Also, my PR worked across all of Emacs (not just in compose buffers) and it was interactive. When invoked with a region selected, the menu options would adapt accordingly. Would you like me to include that as well?

(I'm refering to the PR description in #343)

Also, my PR worked across all of Emacs (not just in compose buffers) and it was interactive. When invoked with a region selected, the menu options would adapt accordingly. Would you like me to include that as well?

I think we need at least 2 transient menus. The compose one is very specific to compose buffer but also right after LLM replied and thus buffer goes read-only.

We can bring in your PR menu also.