Skip to content

Commit 35e904e

Browse files
committed
Remove lto from the release profile
The performance difference has shrunk substantially adding inline to a bunch of functions. The performance difference with or without lto is about 4 seconds on the slowest clip/qp on a standard awcy run (MINECRAFT, objective-1-fast, qp 80). The compile time difference is 42 seconds. If it's possible to have good performance with lto off, then optimizing without it will provide a good development profile. Going forward, it would be advisable to use lto to check for performancem problems. It may be possible to create a seperate profile between dev and release. Would require rust-lang/cargo#6988 and AWCY would need to be modified to use the new profile/still work with old versions of rav1e.
1 parent b14cbc7 commit 35e904e

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,9 @@ debug = true
146146
codegen-units = 1 # if > 1 enables parallel code generation which improves
147147
# compile times, but prevents some optimizations.
148148
# Passes `-C codegen-units`. Ignored when `lto = true`.
149-
lto = true
150149

151150
[profile.bench]
152151
codegen-units = 1
153-
lto = true
154152

155153
[workspace]
156154
members = [".", "ivf", "rav1e_js", "v_frame"]

0 commit comments

Comments
 (0)