Skip to content

Commit 3ec603d

Browse files
committed
opentelemetry-instrumentation-httpx: drop unused private classes (open-telemetry#3036)
1 parent 9e62bdd commit 3ec603d

File tree

2 files changed

+2
-71
lines changed

2 files changed

+2
-71
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3939
([#2971](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2971))
4040
- Drop `opentelemetry-instrumentation-test` package from default instrumentation list
4141
([#2969](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2969))
42+
- `opentelemetry-instrumentation-httpx`: remove private unused `_InstrumentedClient` and `_InstrumentedAsyncClient` classes
43+
([#3036](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3036))
4244

4345
## Version 1.28.0/0.49b0 (2024-11-05)
4446

instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py

-71
Original file line numberDiff line numberDiff line change
@@ -641,77 +641,6 @@ async def aclose(self) -> None:
641641
await self._transport.aclose()
642642

643643

644-
class _InstrumentedClient(httpx.Client):
645-
_tracer_provider = None
646-
_request_hook = None
647-
_response_hook = None
648-
649-
def __init__(self, *args, **kwargs):
650-
super().__init__(*args, **kwargs)
651-
652-
self._original_transport = self._transport
653-
self._original_mounts = self._mounts.copy()
654-
self._is_instrumented_by_opentelemetry = True
655-
656-
self._transport = SyncOpenTelemetryTransport(
657-
self._transport,
658-
tracer_provider=_InstrumentedClient._tracer_provider,
659-
request_hook=_InstrumentedClient._request_hook,
660-
response_hook=_InstrumentedClient._response_hook,
661-
)
662-
self._mounts.update(
663-
{
664-
url_pattern: (
665-
SyncOpenTelemetryTransport(
666-
transport,
667-
tracer_provider=_InstrumentedClient._tracer_provider,
668-
request_hook=_InstrumentedClient._request_hook,
669-
response_hook=_InstrumentedClient._response_hook,
670-
)
671-
if transport is not None
672-
else transport
673-
)
674-
for url_pattern, transport in self._original_mounts.items()
675-
}
676-
)
677-
678-
679-
class _InstrumentedAsyncClient(httpx.AsyncClient):
680-
_tracer_provider = None
681-
_request_hook = None
682-
_response_hook = None
683-
684-
def __init__(self, *args, **kwargs):
685-
super().__init__(*args, **kwargs)
686-
687-
self._original_transport = self._transport
688-
self._original_mounts = self._mounts.copy()
689-
self._is_instrumented_by_opentelemetry = True
690-
691-
self._transport = AsyncOpenTelemetryTransport(
692-
self._transport,
693-
tracer_provider=_InstrumentedAsyncClient._tracer_provider,
694-
request_hook=_InstrumentedAsyncClient._request_hook,
695-
response_hook=_InstrumentedAsyncClient._response_hook,
696-
)
697-
698-
self._mounts.update(
699-
{
700-
url_pattern: (
701-
AsyncOpenTelemetryTransport(
702-
transport,
703-
tracer_provider=_InstrumentedAsyncClient._tracer_provider,
704-
request_hook=_InstrumentedAsyncClient._request_hook,
705-
response_hook=_InstrumentedAsyncClient._response_hook,
706-
)
707-
if transport is not None
708-
else transport
709-
)
710-
for url_pattern, transport in self._original_mounts.items()
711-
}
712-
)
713-
714-
715644
class HTTPXClientInstrumentor(BaseInstrumentor):
716645
# pylint: disable=protected-access,attribute-defined-outside-init
717646
"""An instrumentor for httpx Client and AsyncClient

0 commit comments

Comments
 (0)