Skip to content

Commit fe8518e

Browse files
Kludexxrmx
andcommitted
starlette: Replace _meter_provider by meter_provider on _instrument (open-telemetry#3048)
* starlette: Replace `_meter_provider` by `meter_provider` on `_instrument` * Add PR on the changelog --------- Co-authored-by: Riccardo Magliocchetti <[email protected]>
1 parent 78cecf5 commit fe8518e

File tree

2 files changed

+3
-1
lines changed
  • instrumentation/opentelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette

2 files changed

+3
-1
lines changed

Diff for: CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3232

3333
### Fixed
3434

35+
- `opentelemetry-instrumentation-starlette`: Retrieve `meter_provider` key instead of `_meter_provider` on `_instrument`
36+
([#3048](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3048))
3537
- `opentelemetry-instrumentation-httpx`: instrument_client is a static method again
3638
([#3003](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3003))
3739
- `opentelemetry-instrumentation-system_metrics`: fix callbacks reading wrong config

Diff for: instrumentation/opentelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ def _instrument(self, **kwargs):
265265
_InstrumentedStarlette._client_response_hook = kwargs.get(
266266
"client_response_hook"
267267
)
268-
_InstrumentedStarlette._meter_provider = kwargs.get("_meter_provider")
268+
_InstrumentedStarlette._meter_provider = kwargs.get("meter_provider")
269269

270270
applications.Starlette = _InstrumentedStarlette
271271

0 commit comments

Comments
 (0)