Skip to content

Commit 7da4818

Browse files
committed
fix(wechatpay_download_certs): 重构函数以规避可能的安全问题
1 parent 13e65aa commit 7da4818

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

cmd/wechatpay_download_certs/wechatpay_download_certs.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,34 +44,34 @@ func main() {
4444
flag.Usage = printUsageAndExit
4545

4646
if err := checkArgs(); err != nil {
47-
reportError("参数有误:%v", err)
47+
reportError("参数有误:", err)
4848
printUsageAndExit()
4949
}
5050

5151
ctx := context.Background()
5252
client, err := createClient(ctx)
5353
if err != nil {
54-
reportError("%v", err)
54+
reportError("初始化失败:", err)
5555
os.Exit(errCodeRunError)
5656
}
5757

5858
d, err := downloader.NewCertificateDownloaderWithClient(ctx, client, mchAPIv3Key)
5959
if err != nil {
60-
reportError("下载证书失败:%v", err)
60+
reportError("下载证书失败:", err)
6161
os.Exit(errCodeRunError)
6262
}
6363

6464
err = saveCertificates(ctx, d)
6565
if err != nil {
66-
reportError("%v", err)
66+
reportError("保存证书失败:", err)
6767
os.Exit(errCodeRunError)
6868
}
6969

7070
os.Exit(0)
7171
}
7272

73-
func reportError(format string, a ...interface{}) {
74-
_, _ = fmt.Fprintf(os.Stderr, format+"\n", a...)
73+
func reportError(message string, err error) {
74+
_, _ = fmt.Fprintf(os.Stderr, message+" %v\n", err)
7575
}
7676

7777
func printUsageAndExit() {
@@ -105,7 +105,7 @@ func checkArgs() error {
105105
}
106106

107107
if mchPrivateKeyPath == "" {
108-
return paramError{"商户平台证书路径", mchPrivateKeyPath, "必传"}
108+
return paramError{"商户私钥路径", mchPrivateKeyPath, "必传"}
109109
}
110110

111111
fileInfo, err := os.Stat(mchPrivateKeyPath)

0 commit comments

Comments
 (0)