Skip to content

Commit 1b905ed

Browse files
committed
Support selenium-webdriver 4.22.0 that enables CDP in Firefox by default
This pull request supports selenium-webdriver 4.22.0 that enables CDP in Firefox by default. because Firefox 129 deprecates Chrome DevTools Protocol (CDP). selenium-webdriver 4.22.0 enables CDP explicitly by adding "remote.active-protocols"=>3 . - Steps to reproduce and this commit addresses these failures. ```ruby $ bundle update selenium-webdriver --conservative $ git diff main ../Gemfile.lock diff --git a/Gemfile.lock b/Gemfile.lock index 4e1c049..e05f4b3 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -512,8 +512,9 @@ GEM google-protobuf (~> 3.25) sass-embedded (1.69.6-x86_64-linux-gnu) google-protobuf (~> 3.25) - selenium-webdriver (4.20.1) + selenium-webdriver (4.22.0) base64 (~> 0.2) + logger (~> 1.4) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) websocket (~> 1.0) $ cd actionpack $ bin/test test/dispatch/system_testing/driver_test.rb test/dispatch/system_testing/driver_test.rb Running 18 tests in a single process (parallelization threshold is 50) Run options: --seed 58668 .....F Failure: DriverTest#test_define_extra_capabilities_using_firefox [test/dispatch/system_testing/driver_test.rb:127]: --- expected +++ actual @@ -1 +1 @@ -{"moz:firefoxOptions"=>{"args"=>["--host=127.0.0.1"], "prefs"=>{"browser.startup.homepage"=>"http://www.seleniumhq.com/"}}, "browserName"=>"firefox"} +{"moz:firefoxOptions"=>{"args"=>["--host=127.0.0.1"], "prefs"=>{"remote.active-protocols"=>3, "browser.startup.homepage"=>"http://www.seleniumhq.com/"}}, "browserName"=>"firefox"} bin/test test/dispatch/system_testing/driver_test.rb:113 .F Failure: DriverTest#test_define_extra_capabilities_using_headless_firefox [test/dispatch/system_testing/driver_test.rb:144]: --- expected +++ actual @@ -1 +1 @@ -{"moz:firefoxOptions"=>{"args"=>["-headless", "--host=127.0.0.1"], "prefs"=>{"browser.startup.homepage"=>"http://www.seleniumhq.com/"}}, "browserName"=>"firefox"} +{"moz:firefoxOptions"=>{"args"=>["-headless", "--host=127.0.0.1"], "prefs"=>{"remote.active-protocols"=>3, "browser.startup.homepage"=>"http://www.seleniumhq.com/"}}, "browserName"=>"firefox"} bin/test test/dispatch/system_testing/driver_test.rb:130 .......... Finished in 0.007717s, 2332.3654 runs/s, 4794.3066 assertions/s. 18 runs, 37 assertions, 2 failures, 0 errors, 0 skips ``` - Planned Deprecation of CDP in Firefox https://groups.google.com/a/mozilla.org/g/dev-platform/c/Z6Qu3ZT1MJ0?pli=1 - Add preference to enable CDP in Firefox by default SeleniumHQ/selenium#14091 - [rb] Add logger gem as a runtime dependency rails#14082 SeleniumHQ/selenium#14082
1 parent 2422168 commit 1b905ed

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Gemfile.lock

+2-1
Original file line numberDiff line numberDiff line change
@@ -512,8 +512,9 @@ GEM
512512
google-protobuf (~> 3.25)
513513
sass-embedded (1.69.6-x86_64-linux-gnu)
514514
google-protobuf (~> 3.25)
515-
selenium-webdriver (4.20.1)
515+
selenium-webdriver (4.22.0)
516516
base64 (~> 0.2)
517+
logger (~> 1.4)
517518
rexml (~> 3.2, >= 3.2.5)
518519
rubyzip (>= 1.2.2, < 3.0)
519520
websocket (~> 1.0)

actionpack/test/dispatch/system_testing/driver_test.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ class DriverTest < ActiveSupport::TestCase
120120
expected = {
121121
"moz:firefoxOptions" => {
122122
"args" => ["--host=127.0.0.1"],
123-
"prefs" => { "browser.startup.homepage" => "http://www.seleniumhq.com/" }
123+
"prefs" => { "remote.active-protocols" => 3, "browser.startup.homepage" => "http://www.seleniumhq.com/" }
124124
},
125125
"browserName" => "firefox"
126126
}
@@ -137,7 +137,7 @@ class DriverTest < ActiveSupport::TestCase
137137
expected = {
138138
"moz:firefoxOptions" => {
139139
"args" => ["-headless", "--host=127.0.0.1"],
140-
"prefs" => { "browser.startup.homepage" => "http://www.seleniumhq.com/" }
140+
"prefs" => { "remote.active-protocols" => 3, "browser.startup.homepage" => "http://www.seleniumhq.com/" }
141141
},
142142
"browserName" => "firefox"
143143
}

0 commit comments

Comments
 (0)