Skip to content

ngTouch + ngClick directive on modal window make input elements within modal unfocusable #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbielick opened this issue Sep 5, 2014 · 4 comments

Comments

@jbielick
Copy link

jbielick commented Sep 5, 2014

See this issue thread for more info:
angular-ui/bootstrap#2280

The modal window template is essentially the same between angular-ui-bootstrap and this library, so the issue exists between the two.

This plunker will demonstrate the issue in an simple environment. (use touch screen emulation)

Can anyone comment on why there's an ngClick ng-click="close($event)" on this line ?

From a very shallow level of debugging, I don't see any close method on the modal window's scope or it's parents. Is it necessary? Removing it would solve a lot of ngTouch / ngClick interference between nested / child elements.

screen shot 2014-09-05 at 11 12 36 am

@circlingthesun
Copy link
Contributor

I can confirm this issue and the proposed solution. @jbrowning any idea what the ng-click does?

@jbielick
Copy link
Author

Thanks, y'all.

@jbrowning
Copy link
Member

Thanks for reporting @jbielick. I have no idea what that click handler was doing there. 😃

@jbielick
Copy link
Author

Seemed like it was extraneous. I guess it boils down to a limitation of ngTouch in that any nested ngClick directives are going to have this behavior. But then again, I can't think of a reason that would be necessary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants