From 8e76dca71e6b7543b4e6565b3b6dba0ddfe076e0 Mon Sep 17 00:00:00 2001 From: "Daniel J. O'Quinn" Date: Mon, 22 May 2017 18:00:26 -0400 Subject: [PATCH 1/6] Reword how main function is exported. Build error is Uncaught TypeError: (0 , _reduxMixinsCreator.reduxMixinsCreator) is not a function at eval (eval at (app.js:613), :35:62) at Object. (app.js:613) at __webpack_require__ (app.js:556) at fn (app.js:87) at eval (eval at (app.js:607), :3:1) at Object. (app.js:607) at __webpack_require__ (app.js:556) at fn (app.js:87) at Object. (app.js:587) at __webpack_require__ (app.js:556) --- reduxMixinsCreator.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reduxMixinsCreator.js b/reduxMixinsCreator.js index 7ea31b7..83624cc 100644 --- a/reduxMixinsCreator.js +++ b/reduxMixinsCreator.js @@ -1,7 +1,7 @@ var redux = require('redux'); var bindActionCreators = redux.bindActionCreators; -function reduxMixinsCreator(actionCreators) { +let ReduxMixinsCreator = function(actionCreators) { return { @@ -32,4 +32,4 @@ function reduxMixinsCreator(actionCreators) { } -module.exports = reduxMixinsCreator; +exports.reduxMixinsCreator = ReduxMixinsCreator; From 3fe5afc9f9dcc4f7afc091126406516694a43023 Mon Sep 17 00:00:00 2001 From: "Daniel J. O'Quinn" Date: Mon, 22 May 2017 18:02:32 -0400 Subject: [PATCH 2/6] Import the frozen mixin creator Use the frozen module in the base directory of this project. --- example/src/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example/src/app.js b/example/src/app.js index b9e065f..7748472 100644 --- a/example/src/app.js +++ b/example/src/app.js @@ -10,7 +10,7 @@ const createStoreWithMiddleware = applyMiddleware(logger)(createStore) const store = createStoreWithMiddleware(reducers) import * as ItemAction from './action/ItemAction' -import * as reduxMixinsCreator from 'vue-redux' +import {reduxMixinsCreator} from '../../reduxMixinsCreator'; const reduxMixins = reduxMixinsCreator(ItemAction) new Vue({ From 8b5ed3c840bf2858b5e3a7de0600d34c0e6feea8 Mon Sep 17 00:00:00 2001 From: "Daniel J. O'Quinn" Date: Thu, 6 Jul 2017 22:11:52 -0400 Subject: [PATCH 3/6] Repair broken import statement. --- test/reduxMixinsCreator.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/reduxMixinsCreator.spec.js b/test/reduxMixinsCreator.spec.js index fad4313..d3e648e 100644 --- a/test/reduxMixinsCreator.spec.js +++ b/test/reduxMixinsCreator.spec.js @@ -1,4 +1,4 @@ -var reduxMixinsCreator = require('../reduxMixinsCreator'); +var {reduxMixinsCreator} = require('../reduxMixinsCreator'); var createStore = require('redux').createStore; var expect = require('expect'); var sinon = require('sinon'); From 9445e5a149a9f78ce00700223e7268cb8911b171 Mon Sep 17 00:00:00 2001 From: Daniel O'Quinn Date: Sat, 15 Jul 2017 00:28:31 -0400 Subject: [PATCH 4/6] use trust dist in travis cl --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 4c885a4..e8cbd5e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,4 +1,5 @@ language: node_js +dist: trusty node_js: - "4.2" - "0.12" From 3bfe2f627a14937641696f8504483b5d54000bf8 Mon Sep 17 00:00:00 2001 From: Daniel O'Quinn Date: Sat, 15 Jul 2017 00:34:55 -0400 Subject: [PATCH 5/6] keep backwards compatibility --- example/src/app.js | 2 +- reduxMixinsCreator.js | 2 +- test/reduxMixinsCreator.spec.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/example/src/app.js b/example/src/app.js index 7748472..5dd5f1b 100644 --- a/example/src/app.js +++ b/example/src/app.js @@ -10,7 +10,7 @@ const createStoreWithMiddleware = applyMiddleware(logger)(createStore) const store = createStoreWithMiddleware(reducers) import * as ItemAction from './action/ItemAction' -import {reduxMixinsCreator} from '../../reduxMixinsCreator'; +import reduxMixinsCreator from '../../reduxMixinsCreator'; const reduxMixins = reduxMixinsCreator(ItemAction) new Vue({ diff --git a/reduxMixinsCreator.js b/reduxMixinsCreator.js index 83624cc..10ab5cb 100644 --- a/reduxMixinsCreator.js +++ b/reduxMixinsCreator.js @@ -32,4 +32,4 @@ let ReduxMixinsCreator = function(actionCreators) { } -exports.reduxMixinsCreator = ReduxMixinsCreator; +module.exports = ReduxMixinsCreator; diff --git a/test/reduxMixinsCreator.spec.js b/test/reduxMixinsCreator.spec.js index d3e648e..fac7a61 100644 --- a/test/reduxMixinsCreator.spec.js +++ b/test/reduxMixinsCreator.spec.js @@ -1,4 +1,4 @@ -var {reduxMixinsCreator} = require('../reduxMixinsCreator'); +const reduxMixinsCreator = require('../reduxMixinsCreator'); var createStore = require('redux').createStore; var expect = require('expect'); var sinon = require('sinon'); From f842d0b3c3c6d938d6ff17c186c968378226143a Mon Sep 17 00:00:00 2001 From: Daniel O'Quinn Date: Sat, 15 Jul 2017 00:36:21 -0400 Subject: [PATCH 6/6] dont use let yet --- reduxMixinsCreator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reduxMixinsCreator.js b/reduxMixinsCreator.js index 10ab5cb..2e9a781 100644 --- a/reduxMixinsCreator.js +++ b/reduxMixinsCreator.js @@ -1,7 +1,7 @@ var redux = require('redux'); var bindActionCreators = redux.bindActionCreators; -let ReduxMixinsCreator = function(actionCreators) { +var ReduxMixinsCreator = function(actionCreators) { return {