jsx-fragments: improve message text
#2032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 31, 2018
lib/rules/jsx-fragments.js
Outdated
| @@ -47,7 +47,8 @@ module.exports = { | |||
| if (!versionUtil.testReactVersion(context, '16.2.0')) { | |||
| context.report({ | |||
| node, | |||
| message: 'Fragments are only supported starting from React v16.2' | |||
| message: 'Fragments are only supported starting from React v16.2. ' | |||
| + 'Please disable the `react/jsx-fragments` rule or upgrade your version of React.' | |||
There was a problem hiding this comment.
maybe it’s worth adding “in eslint settings”?
|
@ljharb our tests for ESLint 3 are broken due to eslint/typescript-eslint-parser#526 (when I fix |
alexzherdev
force-pushed
the
jsx-fragments-message
branch
from
a5450cb to
d6f7e1e
Compare
|
Yes, technically that linked commit is a semver-major, and it'd be great if you filed an issue on that repo about it. We'll have to peg to v20 of that dep in the meantime, then. |
EvHaus
approved these changes
Oct 31, 2018
ljharb
reviewed
Oct 31, 2018
package.json
Outdated
| @@ -39,7 +39,7 @@ | |||
| "istanbul": "^0.4.5", | |||
| "mocha": "^5.2.0", | |||
| "typescript": "^3.1.3", | |||
| "typescript-eslint-parser": "^20.0.0" | |||
| "typescript-eslint-parser": "20.0.0" | |||
There was a problem hiding this comment.
i think this is now fixed, so now we can use ^ again
There was a problem hiding this comment.
Right, but should we say ^20.1.1 now?
alexzherdev
force-pushed
the
jsx-fragments-message
branch
from
58e3be7 to
5014b76
Compare
ljharb
force-pushed
the
jsx-fragments-message
branch
from
5014b76 to
7d2eb6a
Compare
1 task
1 task
This was referenced Dec 28, 2018
Closed
This was referenced Jan 8, 2019
ghost
mentioned this pull request
This was referenced Jan 13, 2019
Merged
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.