Skip to content

Commit ea7698a

Browse files
authored
fix(npm-audit): ensure message is a string before trimming for deprec… (#6742)
Fix [Bug?]: TypeError: le.trim is not a function when running yarn npm audit -AR #6554 ## What's the problem this PR addresses? <!-- Describe the rationale of your PR. --> <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) --> Closes #6554 ## How did you fix it? <!-- A detailed description of your implementation. --> Ensure that message is a string, otherwise return the default message ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed. Signed-off-by: Johannes Will <[email protected]>
1 parent 082357f commit ea7698a

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

.yarn/versions/e8aaefb7.yml

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
releases:
2+
"@yarnpkg/cli": patch
3+
"@yarnpkg/plugin-npm-cli": patch
4+
5+
declined:
6+
- "@yarnpkg/plugin-compat"
7+
- "@yarnpkg/plugin-constraints"
8+
- "@yarnpkg/plugin-dlx"
9+
- "@yarnpkg/plugin-essentials"
10+
- "@yarnpkg/plugin-init"
11+
- "@yarnpkg/plugin-interactive-tools"
12+
- "@yarnpkg/plugin-nm"
13+
- "@yarnpkg/plugin-pack"
14+
- "@yarnpkg/plugin-patch"
15+
- "@yarnpkg/plugin-pnp"
16+
- "@yarnpkg/plugin-pnpm"
17+
- "@yarnpkg/plugin-stage"
18+
- "@yarnpkg/plugin-typescript"
19+
- "@yarnpkg/plugin-version"
20+
- "@yarnpkg/plugin-workspace-tools"
21+
- "@yarnpkg/builder"
22+
- "@yarnpkg/core"
23+
- "@yarnpkg/doctor"

packages/plugin-npm-cli/sources/commands/npm/audit.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export default class NpmAuditCommand extends BaseCommand {
161161
auditResult[packageName] ??= [];
162162
auditResult[packageName].push({
163163
id: `${packageName} (deprecation)`,
164-
title: message.trim() || `This package has been deprecated.`,
164+
title: (typeof message === `string` ? message : ``).trim() || `This package has been deprecated.`,
165165
severity: npmAuditTypes.Severity.Moderate,
166166
vulnerable_versions: version,
167167
});

0 commit comments

Comments
 (0)