Skip to content

Commit d3424f3

Browse files
rileyajonesyatbear
authored andcommitted
Chore: Change all copybara expects to legacy variants (tensorflow#6549)
## Motivation for features / changes All the material design components are actually being remapped to the legacy variants internally this is confusing and has already lead to issues like the one being fixed by tensorflow#6547. Googlers see [cl/558173803](http://cl/558173803) for the build rules being added internally. See [cl/559814988](http://cl/559814988) for confidence this will not break sync
1 parent b3edbf3 commit d3424f3

File tree

18 files changed

+116
-116
lines changed

18 files changed

+116
-116
lines changed

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/timeline/BUILD

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ tf_ng_module(
2020
"//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/store",
2121
"//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/store:types",
2222
"//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data",
23-
"//tensorboard/webapp/angular:expect_angular_material_button",
24-
"//tensorboard/webapp/angular:expect_angular_material_slider",
23+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
24+
"//tensorboard/webapp/angular:expect_angular_legacy_material_slider",
2525
"@npm//@angular/common",
2626
"@npm//@angular/core",
2727
"@npm//@ngrx/store",

tensorboard/webapp/alert/views/BUILD

+4-4
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ tf_ng_module(
2626
"//tensorboard/webapp/alert:types",
2727
"//tensorboard/webapp/alert/store",
2828
"//tensorboard/webapp/alert/store:types",
29-
"//tensorboard/webapp/angular:expect_angular_material_button",
30-
"//tensorboard/webapp/angular:expect_angular_material_snackbar",
29+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
30+
"//tensorboard/webapp/angular:expect_angular_legacy_material_snackbar",
3131
"//tensorboard/webapp/util:string",
3232
"@npm//@angular/common",
3333
"@npm//@angular/core",
@@ -49,8 +49,8 @@ tf_ts_library(
4949
"//tensorboard/webapp/alert/store:testing",
5050
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
5151
"//tensorboard/webapp/angular:expect_angular_core_testing",
52-
"//tensorboard/webapp/angular:expect_angular_material_button",
53-
"//tensorboard/webapp/angular:expect_angular_material_snackbar",
52+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
53+
"//tensorboard/webapp/angular:expect_angular_legacy_material_snackbar",
5454
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
5555
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
5656
"@npm//@angular/core",

tensorboard/webapp/angular/BUILD

+21-21
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ tf_ts_library(
7171

7272
# This is a dummy rule used as a @angular/material/autocomplete dependency.
7373
tf_ts_library(
74-
name = "expect_angular_material_autocomplete",
74+
name = "expect_angular_legacy_material_autocomplete",
7575
srcs = [],
7676
deps = [
7777
"@npm//@angular/material",
@@ -87,7 +87,7 @@ tf_ts_library(
8787
],
8888
)
8989

90-
# This is a dummy rule used as a @angular/material/legeacy_checkbox dependency.
90+
# This is a dummy rule used as a @angular/material/legacy_checkbox dependency.
9191
tf_ts_library(
9292
name = "expect_angular_legacy_material_checkbox",
9393
srcs = [],
@@ -107,7 +107,7 @@ tf_ts_library(
107107

108108
# This is a dummy rule used as a @angular/material/button dependency.
109109
tf_ts_library(
110-
name = "expect_angular_material_button",
110+
name = "expect_angular_legacy_material_button",
111111
srcs = [],
112112
deps = [
113113
"@npm//@angular/material",
@@ -125,7 +125,7 @@ tf_ts_library(
125125

126126
# This is a dummy rule used as a @angular/material/chips dependency.
127127
tf_ts_library(
128-
name = "expect_angular_material_chips",
128+
name = "expect_angular_legacy_material_chips",
129129
srcs = [],
130130
deps = [
131131
"@npm//@angular/material",
@@ -134,7 +134,7 @@ tf_ts_library(
134134

135135
# This is a dummy rule used as a @angular/material/dialog dependency.
136136
tf_ts_library(
137-
name = "expect_angular_material_dialog",
137+
name = "expect_angular_legacy_material_dialog",
138138
srcs = [],
139139
deps = [
140140
"@npm//@angular/material",
@@ -143,7 +143,7 @@ tf_ts_library(
143143

144144
# This is a dummy rule used as a @angular/material/dialog/testing dependency.
145145
tf_ts_library(
146-
name = "expect_angular_material_dialog_testing",
146+
name = "expect_angular_legacy_material_dialog_testing",
147147
srcs = [],
148148
deps = [
149149
"@npm//@angular/material",
@@ -152,7 +152,7 @@ tf_ts_library(
152152

153153
# This is a dummy rule used as a @angular/material/expansion dependency.
154154
tf_ts_library(
155-
name = "expect_angular_material_expansion",
155+
name = "expect_angular_legacy_material_expansion",
156156
srcs = [],
157157
deps = [
158158
"@npm//@angular/material",
@@ -161,7 +161,7 @@ tf_ts_library(
161161

162162
# This is a dummy rule used as a @angular/material/expansion dependency.
163163
tf_ts_library(
164-
name = "expect_angular_material_form_field",
164+
name = "expect_angular_legacy_material_form_field",
165165
srcs = [],
166166
deps = [
167167
"@npm//@angular/material",
@@ -188,7 +188,7 @@ tf_ts_library(
188188

189189
# This is a dummy rule used as a @angular/material/input dependency.
190190
tf_ts_library(
191-
name = "expect_angular_material_input",
191+
name = "expect_angular_legacy_material_input",
192192
srcs = [],
193193
deps = [
194194
"@npm//@angular/material",
@@ -197,7 +197,7 @@ tf_ts_library(
197197

198198
# This is a dummy rule used as a @angular/material/menu dependency.
199199
tf_ts_library(
200-
name = "expect_angular_material_menu",
200+
name = "expect_angular_legacy_material_menu",
201201
srcs = [],
202202
deps = [
203203
"@npm//@angular/material",
@@ -206,7 +206,7 @@ tf_ts_library(
206206

207207
# This is a dummy rule used as a @angular/material/menu/testing dependency.
208208
tf_ts_library(
209-
name = "expect_angular_material_menu_testing",
209+
name = "expect_angular_legacy_material_menu_testing",
210210
srcs = [],
211211
deps = [
212212
"@npm//@angular/material",
@@ -215,7 +215,7 @@ tf_ts_library(
215215

216216
# This is a dummy rule used as a @angular/material/paginator dependency.
217217
tf_ts_library(
218-
name = "expect_angular_material_paginator",
218+
name = "expect_angular_legacy_material_paginator",
219219
srcs = [],
220220
deps = [
221221
"@npm//@angular/material",
@@ -224,7 +224,7 @@ tf_ts_library(
224224

225225
# This is a dummy rule used as a @angular/material/progress_spinner dependency.
226226
tf_ts_library(
227-
name = "expect_angular_material_progress_spinner",
227+
name = "expect_angular_legacy_material_progress_spinner",
228228
srcs = [],
229229
deps = [
230230
"@npm//@angular/material",
@@ -233,7 +233,7 @@ tf_ts_library(
233233

234234
# This is a dummy rule used as a @angular/material/select dependency.
235235
tf_ts_library(
236-
name = "expect_angular_material_select",
236+
name = "expect_angular_legacy_material_select",
237237
srcs = [],
238238
deps = [
239239
"@npm//@angular/material",
@@ -242,7 +242,7 @@ tf_ts_library(
242242

243243
# This is a dummy rule used as a @angular/material/select/testing dependency.
244244
tf_ts_library(
245-
name = "expect_angular_material_select_testing",
245+
name = "expect_angular_legacy_material_select_testing",
246246
srcs = [],
247247
deps = [
248248
"@npm//@angular/material",
@@ -251,7 +251,7 @@ tf_ts_library(
251251

252252
# This is a dummy rule used as a @angular/material/slide_toggle dependency.
253253
tf_ts_library(
254-
name = "expect_angular_material_slide_toggle",
254+
name = "expect_angular_legacy_material_slide_toggle",
255255
srcs = [],
256256
deps = [
257257
"@npm//@angular/material",
@@ -260,7 +260,7 @@ tf_ts_library(
260260

261261
# This is a dummy rule used as a @angular/material/slider dependency.
262262
tf_ts_library(
263-
name = "expect_angular_material_slider",
263+
name = "expect_angular_legacy_material_slider",
264264
srcs = [],
265265
deps = [
266266
"@npm//@angular/material",
@@ -269,7 +269,7 @@ tf_ts_library(
269269

270270
# This is a dummy rule used as a @angular/material/snackbar dependency.
271271
tf_ts_library(
272-
name = "expect_angular_material_snackbar",
272+
name = "expect_angular_legacy_material_snackbar",
273273
srcs = [],
274274
deps = [
275275
"@npm//@angular/material",
@@ -287,7 +287,7 @@ tf_ts_library(
287287

288288
# This is a dummy rule used as a @angular/material/table dependency.
289289
tf_ts_library(
290-
name = "expect_angular_material_table",
290+
name = "expect_angular_legacy_material_table",
291291
srcs = [],
292292
deps = [
293293
"@npm//@angular/material",
@@ -296,7 +296,7 @@ tf_ts_library(
296296

297297
# This is a dummy rule used as a @angular/material/tabs dependency.
298298
tf_ts_library(
299-
name = "expect_angular_material_tabs",
299+
name = "expect_angular_legacy_material_tabs",
300300
srcs = [],
301301
deps = [
302302
"@npm//@angular/material",
@@ -314,7 +314,7 @@ tf_ts_library(
314314

315315
# This is a dummy rule used as a @angular/material/tooltip dependency.
316316
tf_ts_library(
317-
name = "expect_angular_material_tooltip",
317+
name = "expect_angular_legacy_material_tooltip",
318318
srcs = [],
319319
deps = [
320320
"@npm//@angular/material",

tensorboard/webapp/core/views/BUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ tf_ng_module(
1717
],
1818
assets = [":layout_styles"],
1919
deps = [
20-
"//tensorboard/webapp/angular:expect_angular_material_button",
20+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
2121
"//tensorboard/webapp/angular:expect_angular_material_icon",
2222
"//tensorboard/webapp/core:state",
2323
"//tensorboard/webapp/core:types",

tensorboard/webapp/feature_flag/views/BUILD

+5-5
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ tf_ng_module(
2424
":feature_flag_dialog",
2525
"//tensorboard/webapp:app_state",
2626
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
27-
"//tensorboard/webapp/angular:expect_angular_material_dialog",
27+
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
2828
"//tensorboard/webapp/feature_flag/actions",
2929
"//tensorboard/webapp/feature_flag/store",
3030
"@npm//@angular/common",
@@ -48,8 +48,8 @@ tf_ng_module(
4848
],
4949
deps = [
5050
"//tensorboard/webapp:app_state",
51-
"//tensorboard/webapp/angular:expect_angular_material_button",
52-
"//tensorboard/webapp/angular:expect_angular_material_select",
51+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
52+
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
5353
"//tensorboard/webapp/feature_flag:types",
5454
"//tensorboard/webapp/feature_flag/actions",
5555
"//tensorboard/webapp/feature_flag/store",
@@ -76,8 +76,8 @@ tf_ng_module(
7676
"//tensorboard/webapp/angular:expect_angular_cdk_testing",
7777
"//tensorboard/webapp/angular:expect_angular_cdk_testing_testbed",
7878
"//tensorboard/webapp/angular:expect_angular_core_testing",
79-
"//tensorboard/webapp/angular:expect_angular_material_dialog",
80-
"//tensorboard/webapp/angular:expect_angular_material_dialog_testing",
79+
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
80+
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog_testing",
8181
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
8282
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
8383
"//tensorboard/webapp/feature_flag:types",

tensorboard/webapp/header/BUILD

+8-8
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ tf_ng_module(
3737
],
3838
deps = [
3939
"//tensorboard/webapp:selectors",
40-
"//tensorboard/webapp/angular:expect_angular_material_button",
40+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
41+
"//tensorboard/webapp/angular:expect_angular_legacy_material_menu",
42+
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
43+
"//tensorboard/webapp/angular:expect_angular_legacy_material_tabs",
4144
"//tensorboard/webapp/angular:expect_angular_material_icon",
42-
"//tensorboard/webapp/angular:expect_angular_material_menu",
43-
"//tensorboard/webapp/angular:expect_angular_material_select",
44-
"//tensorboard/webapp/angular:expect_angular_material_tabs",
4545
"//tensorboard/webapp/angular:expect_angular_material_toolbar",
4646
"//tensorboard/webapp/core",
4747
"//tensorboard/webapp/core/actions",
@@ -70,10 +70,10 @@ tf_ts_library(
7070
"//tensorboard/webapp:selectors",
7171
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
7272
"//tensorboard/webapp/angular:expect_angular_core_testing",
73-
"//tensorboard/webapp/angular:expect_angular_material_button",
74-
"//tensorboard/webapp/angular:expect_angular_material_menu",
75-
"//tensorboard/webapp/angular:expect_angular_material_select",
76-
"//tensorboard/webapp/angular:expect_angular_material_tabs",
73+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
74+
"//tensorboard/webapp/angular:expect_angular_legacy_material_menu",
75+
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
76+
"//tensorboard/webapp/angular:expect_angular_legacy_material_tabs",
7777
"//tensorboard/webapp/angular:expect_angular_material_toolbar",
7878
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
7979
"//tensorboard/webapp/angular:expect_ngrx_store_testing",

tensorboard/webapp/metrics/views/card_renderer/BUILD

+20-20
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ tf_ng_module(
6161
deps = [
6262
"//tensorboard/webapp:app_state",
6363
"//tensorboard/webapp:selectors",
64-
"//tensorboard/webapp/angular:expect_angular_material_button",
65-
"//tensorboard/webapp/angular:expect_angular_material_dialog",
66-
"//tensorboard/webapp/angular:expect_angular_material_input",
67-
"//tensorboard/webapp/angular:expect_angular_material_select",
64+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
65+
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
66+
"//tensorboard/webapp/angular:expect_angular_legacy_material_input",
67+
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
6868
"//tensorboard/webapp/feature_flag/directives",
6969
"//tensorboard/webapp/metrics:types",
7070
"//tensorboard/webapp/metrics/data_source",
@@ -106,9 +106,9 @@ tf_ng_module(
106106
":vis_linked_time_selection_warning",
107107
"//tensorboard/webapp:app_state",
108108
"//tensorboard/webapp:selectors",
109-
"//tensorboard/webapp/angular:expect_angular_material_button",
109+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
110+
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
110111
"//tensorboard/webapp/angular:expect_angular_material_icon",
111-
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
112112
"//tensorboard/webapp/metrics:types",
113113
"//tensorboard/webapp/metrics/actions",
114114
"//tensorboard/webapp/metrics/data_source",
@@ -155,10 +155,10 @@ tf_ng_module(
155155
":utils",
156156
":vis_linked_time_selection_warning",
157157
"//tensorboard/webapp:app_state",
158-
"//tensorboard/webapp/angular:expect_angular_material_button",
158+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
159+
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
160+
"//tensorboard/webapp/angular:expect_angular_legacy_material_slider",
159161
"//tensorboard/webapp/angular:expect_angular_material_icon",
160-
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
161-
"//tensorboard/webapp/angular:expect_angular_material_slider",
162162
"//tensorboard/webapp/feature_flag/directives",
163163
"//tensorboard/webapp/metrics:types",
164164
"//tensorboard/webapp/metrics/actions",
@@ -332,11 +332,11 @@ tf_ng_module(
332332
"//tensorboard/webapp:app_state",
333333
"//tensorboard/webapp:selectors",
334334
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
335-
"//tensorboard/webapp/angular:expect_angular_material_button",
336-
"//tensorboard/webapp/angular:expect_angular_material_dialog",
335+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
336+
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
337+
"//tensorboard/webapp/angular:expect_angular_legacy_material_menu",
338+
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
337339
"//tensorboard/webapp/angular:expect_angular_material_icon",
338-
"//tensorboard/webapp/angular:expect_angular_material_menu",
339-
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
340340
"//tensorboard/webapp/experiments:types",
341341
"//tensorboard/webapp/feature_flag/store",
342342
"//tensorboard/webapp/metrics:types",
@@ -449,13 +449,13 @@ tf_ts_library(
449449
"//tensorboard/webapp:selectors",
450450
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
451451
"//tensorboard/webapp/angular:expect_angular_core_testing",
452-
"//tensorboard/webapp/angular:expect_angular_material_button",
453-
"//tensorboard/webapp/angular:expect_angular_material_dialog",
454-
"//tensorboard/webapp/angular:expect_angular_material_input",
455-
"//tensorboard/webapp/angular:expect_angular_material_menu",
456-
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
457-
"//tensorboard/webapp/angular:expect_angular_material_select",
458-
"//tensorboard/webapp/angular:expect_angular_material_slider",
452+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
453+
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
454+
"//tensorboard/webapp/angular:expect_angular_legacy_material_input",
455+
"//tensorboard/webapp/angular:expect_angular_legacy_material_menu",
456+
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
457+
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
458+
"//tensorboard/webapp/angular:expect_angular_legacy_material_slider",
459459
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
460460
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
461461
"//tensorboard/webapp/experiments:types",

tensorboard/webapp/metrics/views/main_view/BUILD

+6-6
Original file line numberDiff line numberDiff line change
@@ -137,12 +137,12 @@ tf_ng_module(
137137
"//tensorboard/webapp:app_state",
138138
"//tensorboard/webapp:selectors",
139139
"//tensorboard/webapp/angular:expect_angular_cdk_scrolling",
140-
"//tensorboard/webapp/angular:expect_angular_material_autocomplete",
141-
"//tensorboard/webapp/angular:expect_angular_material_button",
140+
"//tensorboard/webapp/angular:expect_angular_legacy_material_autocomplete",
141+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
142+
"//tensorboard/webapp/angular:expect_angular_legacy_material_input",
143+
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
142144
"//tensorboard/webapp/angular:expect_angular_material_button_toggle",
143145
"//tensorboard/webapp/angular:expect_angular_material_icon",
144-
"//tensorboard/webapp/angular:expect_angular_material_input",
145-
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
146146
"//tensorboard/webapp/customization",
147147
"//tensorboard/webapp/metrics:types",
148148
"//tensorboard/webapp/metrics:utils",
@@ -185,8 +185,8 @@ tf_ts_library(
185185
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
186186
"//tensorboard/webapp/angular:expect_angular_cdk_scrolling",
187187
"//tensorboard/webapp/angular:expect_angular_core_testing",
188-
"//tensorboard/webapp/angular:expect_angular_material_autocomplete",
189-
"//tensorboard/webapp/angular:expect_angular_material_button",
188+
"//tensorboard/webapp/angular:expect_angular_legacy_material_autocomplete",
189+
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
190190
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
191191
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
192192
"//tensorboard/webapp/app_routing",

0 commit comments

Comments
 (0)