fix after review

Author: stanislav-shchetinin

.github/workflows/tests.yaml

@@ -1,4 +1,4 @@
-name: PR-check
+name: Tests
 
 on:
   push:

CMakePresets.json

@@ -61,8 +61,8 @@
         "timeout": 1200
       },
       "environment": {
-        "ENDPOINT": "localhost:2136",
-        "DATABASE": "/local"
+        "YDB_ENDPOINT": "localhost:2136",
+        "YDB_DATABASE": "/local"
       }
     },
     {

tests/integration/basic_example_it/basic_example.cpp

@@ -25,6 +25,20 @@ static std::string JoinPath(const std::string& basePath, const std::string& path
     return prefixPathSplit;
 }
 
+RunArgs GetRunArgs() {
+    
+    std::string database = std::getenv("YDB_DATABASE");
+    std::string endpoint = std::getenv("YDB_ENDPOINT");
+
+    auto driverConfig = TDriverConfig()
+        .SetEndpoint(endpoint)
+        .SetDatabase(database)
+        .SetAuthToken(std::getenv("YDB_TOKEN") ? std::getenv("YDB_TOKEN") : "");
+
+    TDriver driver(driverConfig);
+    return {driver, JoinPath(database, "basic")};
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 
 //! Creates sample tables with CrateTable API.
@@ -242,10 +256,6 @@ static TStatus PreparedSelectTransaction(TSession session, const std::string& pa
         return prepareResult;
     }
 
-    if (!prepareResult.IsQueryFromCache()) {
-        std::cerr << "+Finished preparing query: PreparedSelectTransaction" << std::endl;
-    }
-
     auto dataQuery = prepareResult.GetQuery();
 
     auto params = dataQuery.GetParamsBuilder()
@@ -441,7 +451,7 @@ static TStatus ScanQuerySelect(TTableClient client, const std::string& path, std
         if (!streamPart.IsSuccess()) {
             eos = true;
             if (!streamPart.EOS()) {
-                std::cerr << "ScanQuery execution failure: " << streamPart.GetIssues().ToString() << std::endl;
+                return resultScanQuery;
             }
             continue;
         }

tests/integration/basic_example_it/basic_example.h

@@ -26,6 +26,7 @@ NYdb::TParams GetTablesDataParams();
 
 void CreateTables(TTableClient client, const std::string& path);
 void ThrowOnError(const TStatus& status);
+RunArgs GetRunArgs();
 TStatus FillTableDataTransaction(TSession session, const std::string& path);
 std::string SelectSimple(TTableClient client, const std::string& path);
 void UpsertSimple(TTableClient client, const std::string& path);

tests/integration/basic_example_it/main.cpp

@@ -1,6 +1,5 @@
 #include "basic_example.h"
 
-#include <src/util/stream/file.h>
 #include <ydb-cpp-sdk/json_value/ydb_json_value.h>
 
 #include <cstdlib>
@@ -9,20 +8,6 @@
 
 #include <gtest/gtest.h>
 
-RunArgs GetRunArgs() {
-    
-    std::string database = std::getenv("YDB_DATABASE");
-    std::string endpoint = std::getenv("YDB_ENDPOINT");
-
-    auto driverConfig = TDriverConfig()
-        .SetEndpoint(endpoint)
-        .SetDatabase(database)
-        .SetAuthToken(std::getenv("YDB_TOKEN") ? std::getenv("YDB_TOKEN") : "");
-
-    TDriver driver(driverConfig);
-    return {driver, database};
-}
-
 TEST(Integration, BasicExample) {
 
     auto [driver, path] = GetRunArgs();