Skip to content

Commit b2cd1f5

Browse files
committed
some changes
1 parent c660e04 commit b2cd1f5

File tree

4 files changed

+49
-16
lines changed

4 files changed

+49
-16
lines changed

cmake/common.cmake

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,9 @@ function(_ydb_sdk_add_library Tgt)
201201
endfunction()
202202

203203
function(_ydb_sdk_validate_public_headers)
204-
file(GLOB_RECURSE allHeaders RELATIVE ${YDB_SDK_SOURCE_DIR}/include ${YDB_SDK_SOURCE_DIR}/include/ydb-cpp-sdk)
204+
file(GLOB_RECURSE allHeaders RELATIVE ${YDB_SDK_SOURCE_DIR}/include ${YDB_SDK_SOURCE_DIR}/include/ydb-cpp-sdk/*)
205205
file(STRINGS ${YDB_SDK_SOURCE_DIR}/cmake/public_headers.txt specialHeaders)
206+
file(STRINGS ${YDB_SDK_SOURCE_DIR}/cmake/protos_public_headers.txt protosHeaders)
206207
if (NOT MSVC)
207208
list(REMOVE_ITEM specialHeaders library/cpp/deprecated/atomic/atomic_win.h)
208209
endif()
@@ -215,18 +216,38 @@ function(_ydb_sdk_validate_public_headers)
215216
)
216217
endforeach()
217218

219+
add_custom_target(make_validate_proto_headers
220+
COMMAND ${CMAKE_COMMAND} -E
221+
WORKING_DIRECTORY ${YDB_SDK_BINARY_DIR}
222+
)
223+
foreach(path ${protosHeaders})
224+
get_filename_component(relPath ${path} DIRECTORY)
225+
add_custom_command(OUTPUT ${YDB_SDK_BINARY_DIR}/__validate_headers_dir/include/${path}
226+
COMMAND ${CMAKE_COMMAND} -E
227+
copy "${YDB_SDK_BINARY_DIR}/${path}" "${YDB_SDK_BINARY_DIR}/__validate_headers_dir/include/${relPath}"
228+
)
229+
endforeach()
230+
218231
list(REMOVE_ITEM allHeaders
219232
library/cpp/threading/future/core/future-inl.h
220233
library/cpp/threading/future/wait/wait-inl.h
221234
library/cpp/yt/misc/guid-inl.h
222235
)
236+
237+
set(targetHeaders ${allHeaders})
238+
list(APPEND targetHeaders ${protosHeaders})
239+
list(TRANSFORM targetHeaders PREPEND "${YDB_SDK_BINARY_DIR}/__validate_headers_dir/include/")
240+
223241
list(TRANSFORM allHeaders PREPEND "#include <")
224242
list(TRANSFORM allHeaders APPEND ">")
225243
list(JOIN allHeaders "\n" fileContent)
226244

227245
file(WRITE ${YDB_SDK_BINARY_DIR}/__validate_headers_dir/main.cpp ${fileContent})
228246

229-
add_library(validate_public_interface MODULE ${YDB_SDK_BINARY_DIR}/__validate_headers_dir/main.cpp)
247+
add_library(validate_public_interface MODULE
248+
${YDB_SDK_BINARY_DIR}/__validate_headers_dir/main.cpp
249+
${targetHeaders}
250+
)
230251
target_include_directories(validate_public_interface PUBLIC ${YDB_SDK_BINARY_DIR}/__validate_headers_dir/include)
231252
endfunction()
232253

cmake/install.cmake

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -66,23 +66,10 @@ function(_ydb_sdk_install_headers ArgIncludeDir)
6666
)
6767

6868
file(STRINGS ${YDB_SDK_SOURCE_DIR}/cmake/public_headers.txt PublicHeaders)
69+
file(STRINGS ${YDB_SDK_SOURCE_DIR}/cmake/protos_public_headers.txt ProtosPublicHeaders)
6970
if (NOT MSVC)
7071
list(REMOVE_ITEM PublicHeaders library/cpp/deprecated/atomic/atomic_win.h)
7172
endif()
72-
list(APPEND ProtosPublicHeaders
73-
src/api/protos/ydb_federation_discovery.pb.h
74-
src/api/protos/ydb_value.pb.h
75-
src/api/protos/ydb_query.pb.h
76-
src/api/protos/ydb_topic.pb.h
77-
src/api/protos/ydb_table.pb.h
78-
src/api/protos/ydb_query_stats.pb.h
79-
src/api/protos/ydb_import.pb.h
80-
src/api/protos/ydb_export.pb.h
81-
src/api/protos/ydb_coordination.pb.h
82-
src/api/protos/draft/ydb_replication.pb.h
83-
src/library/operation_id/protos/operation_id.pb.h
84-
src/library/yql/public/issue/protos/issue_severity.pb.h
85-
)
8673
foreach(HeaderPath ${PublicHeaders})
8774
get_filename_component(RelInstallPath ${HeaderPath} DIRECTORY)
8875
_ydb_sdk_directory_install(FILES

cmake/protos_public_headers.txt

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
src/api/grpc/draft/ydb_datastreams_v1.grpc.pb.h
2+
src/api/grpc/draft/ydb_datastreams_v1.pb.h
3+
src/api/grpc/ydb_topic_v1.grpc.pb.h
4+
src/api/grpc/ydb_topic_v1.pb.h
5+
src/api/protos/annotations/validation.pb.h
6+
src/api/protos/draft/datastreams.pb.h
7+
src/api/protos/ydb_common.pb.h
8+
src/api/protos/ydb_federation_discovery.pb.h
9+
src/api/protos/ydb_operation.pb.h
10+
src/api/protos/ydb_value.pb.h
11+
src/api/protos/ydb_query.pb.h
12+
src/api/protos/ydb_topic.pb.h
13+
src/api/protos/ydb_table.pb.h
14+
src/api/protos/ydb_scheme.pb.h
15+
src/api/protos/ydb_query_stats.pb.h
16+
src/api/protos/ydb_import.pb.h
17+
src/api/protos/ydb_formats.pb.h
18+
src/api/protos/ydb_issue_message.pb.h
19+
src/api/protos/ydb_export.pb.h
20+
src/api/protos/ydb_coordination.pb.h
21+
src/api/protos/ydb_status_codes.pb.h
22+
src/api/protos/draft/ydb_replication.pb.h
23+
src/library/operation_id/protos/operation_id.pb.h
24+
src/library/yql/public/issue/protos/issue_severity.pb.h

cmake/public_headers.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ util/generic/array_size.h
101101
util/generic/array_ref.h
102102
util/generic/bitops.h
103103
util/generic/bt_exception.h
104+
util/generic/buffer.h
104105
util/generic/cast.h
105106
util/generic/deque.h
106107
util/generic/explicit_type.h

0 commit comments

Comments
 (0)