Skip to content

Commit 024feeb

Browse files
committed
use GetBuildPath
1 parent 99f69af commit 024feeb

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

ydb/core/tx/schemeshard/schemeshard_build_index__progress.cpp

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -265,9 +265,7 @@ THolder<TEvSchemeShard::TEvModifySchemeTransaction> DropBuildPropose(
265265
auto propose = MakeHolder<TEvSchemeShard::TEvModifySchemeTransaction>(ui64(buildInfo.ApplyTxId), ss->TabletID());
266266
propose->Record.SetFailOnExist(true);
267267

268-
auto path = TPath::Init(buildInfo.TablePathId, ss)
269-
.Dive(buildInfo.IndexName)
270-
.Dive(buildInfo.KMeans.WriteTo(true));
268+
auto path = GetBuildPath(ss, buildInfo, buildInfo.KMeans.WriteTo(true));
271269

272270
NKikimrSchemeOp::TModifyScheme& modifyScheme = *propose->Record.AddTransaction();
273271
modifyScheme.SetInternal(true);
@@ -534,8 +532,8 @@ struct TSchemeShard::TIndexBuilder::TTxProgress: public TSchemeShard::TIndexBuil
534532
if (buildInfo.KMeans.Level == 1) {
535533
buildInfo.TablePathId.ToProto(ev->Record.MutablePathId());
536534
} else {
537-
auto path = TPath::Init(buildInfo.TablePathId, Self).Dive(buildInfo.IndexName);
538-
path.Dive(buildInfo.KMeans.ReadFrom())->PathId.ToProto(ev->Record.MutablePathId());
535+
auto path = GetBuildPath(Self, buildInfo, buildInfo.KMeans.ReadFrom());
536+
path->PathId.ToProto(ev->Record.MutablePathId());
539537
}
540538

541539
ev->Record.SetK(buildInfo.KMeans.K);
@@ -657,8 +655,8 @@ struct TSchemeShard::TIndexBuilder::TTxProgress: public TSchemeShard::TIndexBuil
657655
auto ev = MakeHolder<TEvDataShard::TEvPrefixKMeansRequest>();
658656
ev->Record.SetId(ui64(BuildId));
659657

660-
auto path = TPath::Init(buildInfo.TablePathId, Self).Dive(buildInfo.IndexName);
661-
path.Dive(buildInfo.KMeans.ReadFrom())->PathId.ToProto(ev->Record.MutablePathId());
658+
auto path = GetBuildPath(Self, buildInfo, buildInfo.KMeans.ReadFrom());
659+
path->PathId.ToProto(ev->Record.MutablePathId());
662660
path.Rise();
663661
*ev->Record.MutableSettings() = std::get<NKikimrSchemeOp::TVectorIndexKmeansTreeDescription>(
664662
buildInfo.SpecializedIndexDescription).GetSettings().settings();
@@ -701,7 +699,7 @@ struct TSchemeShard::TIndexBuilder::TTxProgress: public TSchemeShard::TIndexBuil
701699
buildInfo.SerializeToProto(Self, ev->Record.MutableColumnBuildSettings());
702700
} else {
703701
if (buildInfo.TargetName.empty()) {
704-
TPath implTable = TPath::Init(buildInfo.TablePathId, Self).Dive(buildInfo.IndexName).Dive(
702+
TPath implTable = GetBuildPath(Self, buildInfo,
705703
buildInfo.IsBuildPrefixedVectorIndex() ? buildInfo.KMeans.WriteTo() : NTableIndex::ImplTable);
706704
buildInfo.TargetName = implTable.PathString();
707705

@@ -743,9 +741,7 @@ struct TSchemeShard::TIndexBuilder::TTxProgress: public TSchemeShard::TIndexBuil
743741

744742
void SendUploadSampleKRequest(TIndexBuildInfo& buildInfo) {
745743
buildInfo.Sample.MakeStrictTop(buildInfo.KMeans.K);
746-
auto path = TPath::Init(buildInfo.TablePathId, Self)
747-
.Dive(buildInfo.IndexName)
748-
.Dive(NTableIndex::NTableVectorKmeansTreeIndex::LevelTable);
744+
auto path = GetBuildPath(Self, buildInfo, NTableIndex::NTableVectorKmeansTreeIndex::LevelTable);
749745
Y_ASSERT(buildInfo.Sample.Rows.size() <= buildInfo.KMeans.K);
750746
auto actor = new TUploadSampleK(path.PathString(),
751747
buildInfo.ScanSettings, Self->SelfId(), ui64(BuildId),
@@ -1328,7 +1324,7 @@ struct TSchemeShard::TIndexBuilder::TTxProgress: public TSchemeShard::TIndexBuil
13281324
auto path = GetBuildPath(Self, buildInfo, buildInfo.KMeans.ReadFrom());
13291325
table = Self->Tables.at(path->PathId);
13301326

1331-
if (!path.IsLocked()) { // lock is needed to prevent its shards from beeing split
1327+
if (!path.IsLocked()) { // lock is needed to prevent table shards from beeing split
13321328
ChangeState(buildInfo.Id, TIndexBuildInfo::EState::LockBuild);
13331329
Progress(buildInfo.Id);
13341330
return false;

0 commit comments

Comments
 (0)