Skip to content

Commit 0c90d96

Browse files
committed
Added QueuedTime into plan
1 parent a29b07b commit 0c90d96

File tree

6 files changed

+26
-2
lines changed

6 files changed

+26
-2
lines changed

ydb/core/kqp/opt/kqp_query_plan.cpp

+18-2
Original file line numberDiff line numberDiff line change
@@ -2243,7 +2243,7 @@ TString AddSimplifiedPlan(const TString& planText, TIntrusivePtr<NOpt::TKqpOptim
22432243
return planJson.GetStringRobust();
22442244
}
22452245

2246-
TString SerializeTxPlans(const TVector<const TString>& txPlans, TIntrusivePtr<NOpt::TKqpOptimizeContext> optCtx, const TString commonPlanInfo = "") {
2246+
TString SerializeTxPlans(const TVector<const TString>& txPlans, TIntrusivePtr<NOpt::TKqpOptimizeContext> optCtx, const TString commonPlanInfo = "", const TString& queryStats = "") {
22472247
NJsonWriter::TBuf writer;
22482248
writer.SetIndentSpaces(2);
22492249

@@ -2266,6 +2266,15 @@ TString SerializeTxPlans(const TVector<const TString>& txPlans, TIntrusivePtr<NO
22662266
writer.BeginObject();
22672267
writer.WriteKey("Node Type").WriteString("Query");
22682268
writer.WriteKey("PlanNodeType").WriteString("Query");
2269+
2270+
if (queryStats) {
2271+
NJson::TJsonValue queryStatsJson;
2272+
NJson::ReadJsonTree(queryStats, &queryStatsJson, true);
2273+
2274+
writer.WriteKey("Stats");
2275+
writer.WriteJsonValue(&queryStatsJson);
2276+
}
2277+
22692278
writer.WriteKey("Plans");
22702279
writer.BeginList();
22712280

@@ -2711,13 +2720,20 @@ TString AddExecStatsToTxPlan(const TString& txPlanJson, const NYql::NDqProto::TD
27112720
}
27122721

27132722
TString SerializeAnalyzePlan(const NKqpProto::TKqpStatsQuery& queryStats) {
2723+
NJsonWriter::TBuf writer;
2724+
writer.BeginObject();
2725+
writer.WriteKey("TotalDurationUs").WriteLongLong(queryStats.GetDurationUs());
2726+
writer.WriteKey("QueuedTimeUs").WriteLongLong(queryStats.GetQueuedTimeUs());
2727+
writer.WriteKey("ProcessCpuTimeUs").WriteLongLong(queryStats.GetWorkerCpuTimeUs());
2728+
writer.EndObject();
2729+
27142730
TVector<const TString> txPlans;
27152731
for (const auto& execStats: queryStats.GetExecutions()) {
27162732
for (const auto& txPlan: execStats.GetTxPlansWithStats()) {
27172733
txPlans.push_back(txPlan);
27182734
}
27192735
}
2720-
return SerializeTxPlans(txPlans, TIntrusivePtr<NOpt::TKqpOptimizeContext>());
2736+
return SerializeTxPlans(txPlans, TIntrusivePtr<NOpt::TKqpOptimizeContext>(), "", writer.Str());
27212737
}
27222738

27232739
TString SerializeScriptPlan(const TVector<const TString>& queryPlans) {

ydb/core/kqp/session_actor/kqp_query_state.h

+1
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ class TKqpQueryState : public TNonCopyable {
114114
bool IsDocumentApiRestricted_ = false;
115115

116116
TInstant StartTime;
117+
TInstant ContinueTime;
117118
NYql::TKikimrQueryDeadlines QueryDeadlines;
118119
TKqpQueryStats QueryStats;
119120
bool KeepSession = false;

ydb/core/kqp/session_actor/kqp_query_stats.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ ui64 CalcRequestUnit(const TKqpQueryStats& stats) {
210210
NKqpProto::TKqpStatsQuery TKqpQueryStats::ToProto() const {
211211
NKqpProto::TKqpStatsQuery result;
212212
result.SetDurationUs(DurationUs);
213+
result.SetQueuedTimeUs(QueuedTimeUs);
213214

214215
if (Compilation) {
215216
result.MutableCompilation()->SetFromCache(Compilation->FromCache);

ydb/core/kqp/session_actor/kqp_query_stats.h

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ namespace NKikimr::NKqp {
88

99
struct TKqpQueryStats {
1010
ui64 DurationUs = 0;
11+
ui64 QueuedTimeUs = 0;
1112
std::optional<TKqpStatsCompile> Compilation;
1213

1314
ui64 WorkerCpuTimeUs = 0;

ydb/core/kqp/session_actor/kqp_session_actor.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,7 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
475475

476476
void Handle(NWorkload::TEvContinueRequest::TPtr& ev) {
477477
YQL_ENSURE(QueryState);
478+
QueryState->ContinueTime = TInstant::Now();
478479

479480
if (ev->Get()->Status == Ydb::StatusIds::UNSUPPORTED) {
480481
LOG_T("Failed to place request in resource pool, feature flag is disabled");
@@ -1551,6 +1552,9 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
15511552

15521553
stats->DurationUs = ((TInstant::Now() - QueryState->StartTime).MicroSeconds());
15531554
stats->WorkerCpuTimeUs = (QueryState->GetCpuTime().MicroSeconds());
1555+
if (const auto continueTime = QueryState->ContinueTime) {
1556+
stats->QueuedTimeUs = (continueTime - QueryState->StartTime).MicroSeconds();
1557+
}
15541558
if (QueryState->CompileResult) {
15551559
stats->Compilation.emplace();
15561560
stats->Compilation->FromCache = (QueryState->CompileStats.FromCache);

ydb/core/protos/kqp_stats.proto

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ message TKqpExecutionExtraStats {
7373
message TKqpStatsQuery {
7474
// Basic stats
7575
uint64 DurationUs = 1;
76+
uint64 QueuedTimeUs = 9;
7677
TKqpStatsCompile Compilation = 2;
7778

7879
reserved 3; // repeated TKqpStatsExecution Executions = 3;

0 commit comments

Comments
 (0)