Review suggestion: add unspecified state for proto

MBkkt · MBkkt · commit 1b16d34ccfd0 · 2024-09-06T14:53:46.000Z
diff --git a/ydb/core/protos/tx_datashard.proto b/ydb/core/protos/tx_datashard.proto
@@ -1505,6 +1505,7 @@ message TEvLocalKMeansRequest {
     optional uint32 K = 10;
 
     enum EState {
+        UNSPECIFIED = 0;
         SAMPLE = 1;
         KMEANS = 2;
         UPLOAD_MAIN_TO_TMP = 3;
diff --git a/ydb/core/tx/datashard/local_kmeans.cpp b/ydb/core/tx/datashard/local_kmeans.cpp
@@ -608,8 +608,8 @@ class TLocalKMeansScan final: public TLocalKMeansScanBase, private TCalculation<
                 return FeedUploadTmp2Tmp(key, row);
             case EState::UPLOAD_TMP_TO_POSTING:
                 return FeedUploadTmp2Posting(key, row);
-            case EState::DONE:
-                Y_UNREACHABLE();
+            default:
+                return EScan::Final;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -608,8 +608,8 @@ class TLocalKMeansScan final: public TLocalKMeansScanBase, private TCalculation<`
`608`	`608`	`return FeedUploadTmp2Tmp(key, row);`
`609`	`609`	`case EState::UPLOAD_TMP_TO_POSTING:`
`610`	`610`	`return FeedUploadTmp2Posting(key, row);`
`611`		`- case EState::DONE:`
`612`		`- Y_UNREACHABLE();`
	`611`	`+ default:`
	`612`	`+ return EScan::Final;`
`613`	`613`	`}`
`614`	`614`	`}`
`615`	`615`