extra details added to error message (#9539)

Author: gridnevvvit

ydb/core/kqp/rm_service/kqp_rm_service.cpp

@@ -289,6 +289,7 @@ class TKqpResourceManager : public IKqpResourceManager {
 
         if (!hasScanQueryMemory) {
             Counters->RmNotEnoughMemory->Inc();
+            tx->AckFailedMemoryAlloc(resources.Memory);
             TStringBuilder reason;
             reason << "TxId: " << txId << ", taskId: " << taskId << ". Not enough memory for query, requested: " << resources.Memory
                 << ". " << tx->ToString();
@@ -302,6 +303,7 @@ class TKqpResourceManager : public IKqpResourceManager {
         Y_DEFER {
             if (!result) {
                 Counters->RmNotEnoughMemory->Inc();
+                tx->AckFailedMemoryAlloc(resources.Memory);
                 with_lock (Lock) {
                     TotalMemoryResource->Release(resources.Memory);
                     if (!tx->PoolId.empty()) {

ydb/core/kqp/rm_service/kqp_rm_service.h

@@ -10,6 +10,7 @@
 
 #include <util/datetime/base.h>
 #include <util/string/builder.h>
+#include <util/stream/format.h>
 
 #include "kqp_resource_estimation.h"
 
@@ -122,6 +123,8 @@ class TTxState : public TAtomicRefCount<TTxState> {
     std::atomic<ui64> TxScanQueryMemory = 0;
     std::atomic<ui64> TxExternalDataQueryMemory = 0;
     std::atomic<ui32> TxExecutionUnits = 0;
+    std::atomic<ui64> TxMaxAllocation = 0;
+    std::atomic<ui64> TxFailedAllocation = 0;
 
 public:
     explicit TTxState(ui64 txId, TInstant now, TIntrusivePtr<TKqpCounters> counters, const TString& poolId, const double memoryPoolPercent,
@@ -145,12 +148,14 @@ class TTxState : public TAtomicRefCount<TTxState> {
 
         if (!PoolId.empty()) {
             res << ", PoolId: " << PoolId
-                << ", MemoryPoolPercent: " << Sprintf("%.2f", MemoryPoolPercent);
+                << ", MemoryPoolPercent: " << Sprintf("%.2f", MemoryPoolPercent > 0 ? MemoryPoolPercent : 100);
         }
 
-        res << ", memory initially granted resources: " << TxExternalDataQueryMemory.load()
-            << ", tx total allocations " << TxScanQueryMemory.load()
-            << ", execution units: " << TxExecutionUnits.load()
+        res << ", tx initially granted memory: " << HumanReadableSize(TxExternalDataQueryMemory.load(), SF_BYTES)
+            << ", tx total memory allocations: " << HumanReadableSize(TxScanQueryMemory.load(), SF_BYTES)
+            << ", tx largest successful memory allocation: " << HumanReadableSize(TxMaxAllocation.load(), SF_BYTES)
+            << ", tx largest failed memory allocation: " << HumanReadableSize(TxFailedAllocation.load(), SF_BYTES)
+            << ", tx total execution units: " << TxExecutionUnits.load()
             << ", started at: " << CreatedAt
             << " }";
 
@@ -161,6 +166,11 @@ class TTxState : public TAtomicRefCount<TTxState> {
         return TxScanQueryMemory.load();
     }
 
+    void AckFailedMemoryAlloc(ui64 memory) {
+        ui64 maxAlloc = TxFailedAllocation.load();
+        while(maxAlloc < memory && !TxFailedAllocation.compare_exchange_weak(maxAlloc, memory));
+    }
+
     void Released(TIntrusivePtr<TTaskState>& taskState, const TKqpResourcesRequest& resources) {
         if (resources.ExecutionUnits) {
             Counters->RmOnCompleteFree->Inc();
@@ -176,6 +186,9 @@ class TTxState : public TAtomicRefCount<TTxState> {
         taskState->ScanQueryMemory -= resources.Memory;
         Counters->RmMemory->Sub(resources.Memory);
 
+        ui64 maxAlloc = TxMaxAllocation.load();
+        while(maxAlloc < resources.Memory && !TxMaxAllocation.compare_exchange_weak(maxAlloc, resources.Memory));
+
         TxExecutionUnits.fetch_sub(resources.ExecutionUnits);
         taskState->ExecutionUnits -= resources.ExecutionUnits;
         Counters->RmComputeActors->Sub(resources.ExecutionUnits);