Remove unnecessary string allocation

Vadim Averin · Vadim Averin · commit 2e50767d03c2 · 2024-01-24T08:41:37.000Z
diff --git a/ydb/library/yql/udfs/common/ip_base/lib/ip_base_udf.h b/ydb/library/yql/udfs/common/ip_base/lib/ip_base_udf.h
@@ -231,9 +231,7 @@ namespace {
     }
 
     SIMPLE_STRICT_UDF(TSubnetFromString, TOptionalString(TAutoMapString)) {
-        TStringRef strRef = args[0].AsStringRef();
-        TString str(strRef.Data(), strRef.Data() + strRef.Size());
-        TIpAddressRange range = TIpAddressRange::FromCompactString(str);
+        TIpAddressRange range = TIpAddressRange::FromCompactString(args[0].AsStringRef());
         auto res = SerializeSubnet(range);
         return res ? valueBuilder->NewString(res) : TUnboxedValue(TUnboxedValuePod());
     }

Original file line number	Diff line number	Diff line change
`@@ -231,9 +231,7 @@ namespace {`
`231`	`231`	`}`
`232`	`232`
`233`	`233`	`SIMPLE_STRICT_UDF(TSubnetFromString, TOptionalString(TAutoMapString)) {`
`234`		`- TStringRef strRef = args[0].AsStringRef();`
`235`		`- TString str(strRef.Data(), strRef.Data() + strRef.Size());`
`236`		`- TIpAddressRange range = TIpAddressRange::FromCompactString(str);`
	`234`	`+ TIpAddressRange range = TIpAddressRange::FromCompactString(args[0].AsStringRef());`
`237`	`235`	`auto res = SerializeSubnet(range);`
`238`	`236`	`return res ? valueBuilder->NewString(res) : TUnboxedValue(TUnboxedValuePod());`
`239`	`237`	`}`