Skip to content

Commit 3572906

Browse files
committed
Removed token changes
1 parent 13b048e commit 3572906

File tree

3 files changed

+9
-28
lines changed

3 files changed

+9
-28
lines changed

ydb/core/kqp/workload_service/actors/scheme_actors.cpp

+7-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,13 @@ class TPoolResolverActor : public TActorBootstrapped<TPoolResolverActor> {
6666
for (const TString& usedSid : AppData()->AdministrationAllowedSIDs) {
6767
diffAcl.AddAccess(NACLib::EAccessType::Allow, NACLib::EAccessRights::GenericFull, usedSid);
6868
}
69-
diffAcl.AddAccess(NACLib::EAccessType::Allow, NACLib::EAccessRights::SelectRow | NACLib::EAccessRights::DescribeSchema, AppData()->AllAuthenticatedUsers);
69+
70+
auto useAccess = NACLib::EAccessRights::SelectRow | NACLib::EAccessRights::DescribeSchema;
71+
for (const auto& userSID : AppData()->DefaultUserSIDs) {
72+
diffAcl.AddAccess(NACLib::EAccessType::Allow, useAccess, userSID);
73+
}
74+
diffAcl.AddAccess(NACLib::EAccessType::Allow, useAccess, AppData()->AllAuthenticatedUsers);
75+
diffAcl.AddAccess(NACLib::EAccessType::Allow, useAccess, BUILTIN_ACL_ROOT);
7076

7177
auto token = MakeIntrusive<NACLib::TUserToken>(BUILTIN_ACL_METADATA, TVector<NACLib::TSID>{});
7278
Register(CreatePoolCreatorActor(SelfId(), Event->Get()->Database, Event->Get()->PoolId, NResourcePool::TPoolSettings(), token, diffAcl));

ydb/core/kqp/workload_service/kqp_workload_service.cpp

-26
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,6 @@ class TKqpWorkloadService : public TActorBootstrapped<TKqpWorkloadService> {
132132
return;
133133
}
134134

135-
// Add AllAuthenticatedUsers group SID into user token
136-
ev->Get()->UserToken = GetUserToken(ev->Get()->UserToken);
137-
138135
LOG_D("Recieved new request from " << workerActorId << ", Database: " << ev->Get()->Database << ", PoolId: " << ev->Get()->PoolId << ", SessionId: " << ev->Get()->SessionId);
139136
bool hasDefaultPool = DatabasesWithDefaultPool.contains(CanonizePath(ev->Get()->Database));
140137
Register(CreatePoolResolverActor(std::move(ev), hasDefaultPool, EnabledResourcePoolsOnServerless));
@@ -475,29 +472,6 @@ class TKqpWorkloadService : public TActorBootstrapped<TKqpWorkloadService> {
475472
Send(replyActorId, new TEvCleanupResponse(status, {NYql::TIssue(message)}));
476473
}
477474

478-
static TIntrusivePtr<NACLib::TUserToken> GetUserToken(TIntrusiveConstPtr<NACLib::TUserToken> userToken) {
479-
auto token = MakeIntrusive<NACLib::TUserToken>(userToken ? userToken->GetUserSID() : NACLib::TSID(), TVector<NACLib::TSID>{});
480-
481-
bool hasAllAuthenticatedUsersSID = false;
482-
const auto& allAuthenticatedUsersSID = AppData()->AllAuthenticatedUsers;
483-
if (userToken) {
484-
for (const auto& groupSID : userToken->GetGroupSIDs()) {
485-
token->AddGroupSID(groupSID);
486-
hasAllAuthenticatedUsersSID = hasAllAuthenticatedUsersSID || groupSID == allAuthenticatedUsersSID;
487-
}
488-
}
489-
490-
if (!hasAllAuthenticatedUsersSID) {
491-
token->AddGroupSID(allAuthenticatedUsersSID);
492-
}
493-
494-
if (userToken && !userToken->GetSerializedToken().empty()) {
495-
token->SaveSerializationInfo();
496-
}
497-
498-
return token;
499-
}
500-
501475
TPoolState* GetPoolState(const TString& database, const TString& poolId) {
502476
return GetPoolState(GetPoolKey(database, poolId));
503477
}

ydb/core/kqp/workload_service/ut/kqp_workload_service_actors_ut.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ Y_UNIT_TEST_SUITE(KqpWorkloadServiceActors) {
110110

111111
// Check default pool access
112112
TSampleQueries::TSelect42::CheckResult(ydb->ExecuteQuery(TSampleQueries::TSelect42::Query, settings.UserSID(userSID)));
113-
TSampleQueries::TSelect42::CheckResult(ydb->ExecuteQuery(TSampleQueries::TSelect42::Query, settings.UserSID("")));
113+
TSampleQueries::TSelect42::CheckResult(ydb->ExecuteQuery(TSampleQueries::TSelect42::Query, settings.UserSID(ydb->GetRuntime()->GetAppData().AllAuthenticatedUsers)));
114+
TSampleQueries::TSelect42::CheckResult(ydb->ExecuteQuery(TSampleQueries::TSelect42::Query, settings.UserSID(BUILTIN_ACL_ROOT)));
114115
}
115116

116117
Y_UNIT_TEST(TestDefaultPoolAdminPermissions) {

0 commit comments

Comments
 (0)