try..catch on svg processing in benchmarks (#10149)

iddqdex · web-flow · commit 6361cf3ace49 · 2024-10-07T13:05:44.000+03:00
diff --git a/ydb/public/lib/ydb_cli/commands/ydb_benchmark.cpp b/ydb/public/lib/ydb_cli/commands/ydb_benchmark.cpp
@@ -475,9 +475,13 @@ void TWorkloadCommandBenchmark::SavePlans(const BenchmarkUtils::TQueryBenchmarkR
         }
         {
             TPlanVisualizer pv;
-            pv.LoadPlans(res.GetQueryPlan());
             TFileOutput out(planFName + "svg");
-            out << pv.PrintSvgSafe();
+            try {
+                pv.LoadPlans(res.GetQueryPlan());
+                out << pv.PrintSvg();
+            } catch (std::exception& e) {
+                out << "<svg width='1024' height='256' xmlns='http://www.w3.org/2000/svg'><text>" << e.what() << "<text></svg>";
+            }
         }
     }
     if (res.GetPlanAst()) {

Original file line number	Diff line number	Diff line change
`@@ -475,9 +475,13 @@ void TWorkloadCommandBenchmark::SavePlans(const BenchmarkUtils::TQueryBenchmarkR`
`475`	`475`	`}`
`476`	`476`	`{`
`477`	`477`	`TPlanVisualizer pv;`
`478`		`- pv.LoadPlans(res.GetQueryPlan());`
`479`	`478`	`TFileOutput out(planFName + "svg");`
`480`		`- out << pv.PrintSvgSafe();`
	`479`	`+ try {`
	`480`	`+ pv.LoadPlans(res.GetQueryPlan());`
	`481`	`+ out << pv.PrintSvg();`
	`482`	`+ } catch (std::exception& e) {`
	`483`	`+ out << "<svg width='1024' height='256' xmlns='http://www.w3.org/2000/svg'><text>" << e.what() << "<text></svg>";`
	`484`	`+ }`
`481`	`485`	`}`
`482`	`486`	`}`
`483`	`487`	`if (res.GetPlanAst()) {`