Skip to content

Commit 733ba5a

Browse files
authored
Merge 5650ee2 into 985cdc2
2 parents 985cdc2 + 5650ee2 commit 733ba5a

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

ydb/core/kqp/opt/kqp_opt_build_txs.cpp

+2-4
Original file line numberDiff line numberDiff line change
@@ -495,16 +495,14 @@ class TKqpBuildTxsTransformer : public TSyncTransformerBase {
495495
{
496496
BuildTxTransformer = new TKqpBuildTxTransformer();
497497

498-
const bool enableSpillingGenericQuery =
499-
kqpCtx->IsGenericQuery() && config->SpillingEnabled() &&
500-
config->EnableSpillingGenericQuery;
498+
config->EnableSpillingGenericQuery &= (kqpCtx->IsGenericQuery() && config->SpillingEnabled());
501499

502500
DataTxTransformer = TTransformationPipeline(&typesCtx)
503501
.AddServiceTransformers()
504502
.Add(TExprLogTransformer::Sync("TxOpt", NYql::NLog::EComponent::ProviderKqp, NYql::NLog::ELevel::TRACE), "TxOpt")
505503
.Add(*TypeAnnTransformer, "TypeAnnotation")
506504
.AddPostTypeAnnotation(/* forSubgraph */ true)
507-
.Add(CreateKqpBuildPhyStagesTransformer(enableSpillingGenericQuery, typesCtx, config->BlockChannelsMode), "BuildPhysicalStages")
505+
.Add(CreateKqpBuildPhyStagesTransformer(config->EnableSpillingGenericQuery, typesCtx, config->BlockChannelsMode), "BuildPhysicalStages")
508506
// TODO(ilezhankin): "BuildWideBlockChannels" transformer is required only for BLOCK_CHANNELS_FORCE mode.
509507
.Add(CreateKqpBuildWideBlockChannelsTransformer(typesCtx, config->BlockChannelsMode), "BuildWideBlockChannels")
510508
.Add(*BuildTxTransformer, "BuildPhysicalTx")

ydb/core/protos/table_service_config.proto

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ message TTableServiceConfig {
5555

5656
message TSpillingServiceConfig {
5757
message TLocalFileConfig {
58-
optional bool Enable = 1 [default = true];
58+
optional bool Enable = 1 [default = false];
5959
optional string Root = 2 [default = ""];
6060
optional uint64 MaxTotalSize = 3 [default = 21474836480]; // 20 GiB
6161
optional uint64 MaxFileSize = 4 [default = 5368709120]; // 5 GiB
@@ -309,7 +309,7 @@ message TTableServiceConfig {
309309

310310
optional bool EnableImplicitQueryParameterTypes = 66 [ default = false ];
311311

312-
optional string EnableSpillingNodes = 67 [ default = "All" ];
312+
optional string EnableSpillingNodes = 67 [ default = "" ];
313313

314314
message TComputeSchedulerSettings {
315315
optional uint64 AdvanceTimeIntervalUsec = 1 [default = 50000];

0 commit comments

Comments
 (0)