Skip to content

Commit 75aea0d

Browse files
authored
Cleanup offload actor (#6702)
1 parent 9cd45d0 commit 75aea0d

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

ydb/core/persqueue/offload_actor.cpp

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
#include <ydb/library/actors/core/actor.h>
1313
#include <ydb/library/actors/core/actor_bootstrapped.h>
14+
#include <ydb/library/actors/core/log.h>
1415
#include <ydb/library/services/services.pb.h>
1516
#include <ydb/library/yverify_stream/yverify_stream.h>
1617

@@ -34,7 +35,6 @@ class TOffloadActor
3435
const TActorId ParentTablet;
3536
const ui32 Partition;
3637
const NKikimrPQ::TOffloadConfig Config;
37-
const TPathId DstPathId;
3838

3939
mutable TMaybe<TString> LogPrefix;
4040
TActorId Worker;
@@ -60,14 +60,27 @@ class TOffloadActor
6060
: ParentTablet(parentTablet)
6161
, Partition(partition)
6262
, Config(config)
63-
, DstPathId(PathIdFromPathId(config.GetIncrementalBackup().GetDstPathId()))
6463
{}
6564

65+
auto CreateReaderFactory() {
66+
return [=]() -> IActor* {
67+
return NBackup::NImpl::CreateLocalPartitionReader(ParentTablet, Partition);
68+
};
69+
}
70+
71+
auto CreateWriterFactory() {
72+
return [=]() -> IActor* {
73+
return NBackup::NImpl::CreateLocalTableWriter(
74+
PathIdFromPathId(Config.GetIncrementalBackup().GetDstPathId()));
75+
};
76+
}
77+
6678
void Bootstrap() {
6779
auto* workerActor = CreateWorker(
6880
SelfId(),
69-
[=]() -> IActor* { return NBackup::NImpl::CreateLocalPartitionReader(ParentTablet, Partition); },
70-
[=]() -> IActor* { return NBackup::NImpl::CreateLocalTableWriter(DstPathId); });
81+
CreateReaderFactory(),
82+
CreateWriterFactory());
83+
7184
Worker = TActivationContext::Register(workerActor);
7285

7386
Become(&TOffloadActor::StateWork);
@@ -76,8 +89,7 @@ class TOffloadActor
7689
STATEFN(StateWork) {
7790
switch (ev->GetTypeRewrite()) {
7891
default:
79-
Y_VERIFY_S(false, "Unhandled event type: " << ev->GetTypeRewrite()
80-
<< " event: " << ev->ToString());
92+
LOG_W("Unhandled event type: " << ev->GetTypeRewrite() << " event: " << ev->ToString());
8193
}
8294
}
8395
};

0 commit comments

Comments
 (0)