fix use after free on follower deletion (#10863)

vporyadke · web-flow · commit 77e23b84c31f · 2024-10-25T00:05:40.000+03:00
diff --git a/ydb/core/mind/hive/hive_impl.cpp b/ydb/core/mind/hive/hive_impl.cpp
@@ -257,12 +257,12 @@ void THive::ExecuteProcessBootQueue(NIceDb::TNiceDb& db, TSideEffects& sideEffec
                         sideEffects.Send(actorToNotify, new TEvPrivate::TEvRestartComplete(tablet->GetFullTabletId(), "boot delay"));
                     }
                     tablet->ActorsToNotifyOnRestart.clear();
+                    tablet->InWaitQueue = true;
                     if (tablet->IsFollower()) {
                         TLeaderTabletInfo& leader = tablet->GetLeader();
-                        UpdateTabletFollowersNumber(leader, db, sideEffects);
+                        UpdateTabletFollowersNumber(leader, db, sideEffects); // this may delete tablet
                     }
                     BootQueue.AddToWaitQueue(record); // waiting for new node
-                    tablet->InWaitQueue = true;
                     continue;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -257,12 +257,12 @@ void THive::ExecuteProcessBootQueue(NIceDb::TNiceDb& db, TSideEffects& sideEffec`
`257`	`257`	`sideEffects.Send(actorToNotify, new TEvPrivate::TEvRestartComplete(tablet->GetFullTabletId(), "boot delay"));`
`258`	`258`	`}`
`259`	`259`	`tablet->ActorsToNotifyOnRestart.clear();`
	`260`	`+ tablet->InWaitQueue = true;`
`260`	`261`	`if (tablet->IsFollower()) {`
`261`	`262`	`TLeaderTabletInfo& leader = tablet->GetLeader();`
`262`		`- UpdateTabletFollowersNumber(leader, db, sideEffects);`
	`263`	`+ UpdateTabletFollowersNumber(leader, db, sideEffects); // this may delete tablet`
`263`	`264`	`}`
`264`	`265`	`BootQueue.AddToWaitQueue(record); // waiting for new node`
`265`		`- tablet->InWaitQueue = true;`
`266`	`266`	`continue;`
`267`	`267`	`}`
`268`	`268`	`}`