Skip to content

Commit 7a8d731

Browse files
authored
fix tests TopicPeriodicStat* (#717)
* fix tests TopicPeriodicStat* * remove unnecasary spaces
1 parent 9b35c0e commit 7a8d731

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

ydb/core/tx/schemeshard/ut_helpers/ls_checks.cpp

+8-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace NLs {
1313

1414
using namespace NKikimr;
1515

16-
#define DESCRIBE_ASSERT_EQUAL(name, type, expression, description) \
16+
#define DESCRIBE_ASSERT(op, name, type, expression, description) \
1717
TCheckFunc name(type expected) { \
1818
return [=] (const NKikimrScheme::TEvDescribeSchemeResult& record) { \
1919
UNIT_ASSERT_C(IsGoodDomainStatus(record.GetStatus()), "Unexpected status: " << record.GetStatus()); \
@@ -22,13 +22,16 @@ using namespace NKikimr;
2222
const auto& subdomain = pathDescr.GetDomainDescription(); \
2323
const auto& value = expression; \
2424
\
25-
UNIT_ASSERT_EQUAL_C(value, expected, \
25+
UNIT_ASSERT_##op(value, expected, \
2626
description << " mismatch, subdomain with id " << subdomain.GetDomainKey().GetPathId() << \
2727
" has value " << value << \
2828
" but expected " << expected); \
2929
}; \
3030
}
3131

32+
#define DESCRIBE_ASSERT_EQUAL(name, type, expression, description) DESCRIBE_ASSERT(EQUAL_C, name, type, expression, description)
33+
#define DESCRIBE_ASSERT_GE(name, type, expression, description) DESCRIBE_ASSERT(GE_C, name, type, expression, description)
34+
3235

3336
void NotInSubdomain(const NKikimrScheme::TEvDescribeSchemeResult& record) {
3437
UNIT_ASSERT(record.HasPathDescription());
@@ -671,6 +674,7 @@ TCheckFunc PQPartitionsInsideDomain(ui64 count) {
671674

672675
DESCRIBE_ASSERT_EQUAL(TopicReservedStorage, ui64, subdomain.GetDiskSpaceUsage().GetTopics().GetReserveSize(), "Topic ReserveSize")
673676
DESCRIBE_ASSERT_EQUAL(TopicAccountSize, ui64, subdomain.GetDiskSpaceUsage().GetTopics().GetAccountSize(), "Topic AccountSize")
677+
DESCRIBE_ASSERT_GE(TopicAccountSizeGE, ui64, subdomain.GetDiskSpaceUsage().GetTopics().GetAccountSize(), "Topic AccountSize")
674678
DESCRIBE_ASSERT_EQUAL(TopicUsedReserveSize, ui64, subdomain.GetDiskSpaceUsage().GetTopics().GetUsedReserveSize(), "Topic UsedReserveSize")
675679

676680
TCheckFunc PathsInsideDomainOneOf(TSet<ui64> variants) {
@@ -1185,6 +1189,8 @@ TCheckFunc ServerlessComputeResourcesMode(NKikimrSubDomains::EServerlessComputeR
11851189
}
11861190

11871191
#undef DESCRIBE_ASSERT_EQUAL
1192+
#undef DESCRIBE_ASSERT_GE
1193+
#undef DESCRIBE_ASSERT
11881194

11891195
} // NLs
11901196
} // NSchemeShardUT_Private

ydb/core/tx/schemeshard/ut_helpers/ls_checks.h

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ namespace NLs {
3636
TCheckFunc PQPartitionsInsideDomain(ui64 count);
3737
TCheckFunc TopicReservedStorage(ui64 expected);
3838
TCheckFunc TopicAccountSize(ui64 expected);
39+
TCheckFunc TopicAccountSizeGE(ui64 expected);
3940
TCheckFunc TopicUsedReserveSize(ui64 expected);
4041
TCheckFunc PathsInsideDomainOneOf(TSet<ui64> variants);
4142
TCheckFunc ShardsInsideDomain(ui64 count);

ydb/core/tx/schemeshard/ut_stats/ut_stats.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ Y_UNIT_TEST_SUITE(TSchemeshardStatsBatchingTest) {
480480
const auto Assert = [&] (ui64 expectedAccountSize, ui64 expectedUsedReserveSize) {
481481
TestDescribeResult(DescribePath(runtime,topicPath),
482482
{NLs::Finished,
483-
NLs::TopicAccountSize(expectedAccountSize),
483+
NLs::TopicAccountSizeGE(expectedAccountSize),
484484
NLs::TopicUsedReserveSize(expectedUsedReserveSize)});
485485
};
486486

@@ -550,7 +550,7 @@ Y_UNIT_TEST_SUITE(TSchemeshardStatsBatchingTest) {
550550
const auto AssertTopicSize = [&] (ui64 expectedAccountSize, ui64 expectedUsedReserveSize) {
551551
TestDescribeResult(DescribePath(runtime, "/MyRoot/Topic1"),
552552
{NLs::Finished,
553-
NLs::TopicAccountSize(expectedAccountSize),
553+
NLs::TopicAccountSizeGE(expectedAccountSize),
554554
NLs::TopicUsedReserveSize(expectedUsedReserveSize)});
555555
};
556556

0 commit comments

Comments
 (0)