Skip to content

Commit 85d4495

Browse files
authored
[KIKIMR-21472] Output the final AST in explain query (#6487)
1 parent 47b767b commit 85d4495

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

ydb/core/kqp/host/kqp_explain_prepared.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class TKqpExplainPreparedTransformer : public NYql::TGraphTransformerBase {
6666

6767
PhyQuerySetTxPlans(query, TKqpPhysicalQuery(TransformCtx->ExplainTransformerInput), std::move(TxResults),
6868
ctx, Cluster, TransformCtx->Tables, TransformCtx->Config, TypeCtx, OptimizeCtx);
69-
query.SetQueryAst(KqpExprToPrettyString(*TransformCtx->ExplainTransformerInput, ctx));
69+
query.SetQueryAst(KqpExprToPrettyString(*input, ctx));
7070

7171
TransformCtx->ExplainTransformerInput = nullptr;
7272
return TStatus::Ok;

ydb/core/kqp/ut/olap/helpers/aggregation.h

+3-7
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,7 @@ class TAggregationTestCase {
8181
bool UseLlvm = true;
8282
public:
8383
void FillExpectedAggregationGroupByPlanOptions() {
84-
#if SSA_RUNTIME_VERSION >= 2U
85-
// AddExpectedPlanOptions("TKqpOlapAgg");
8684
AddExpectedPlanOptions("WideCombiner");
87-
#else
88-
AddExpectedPlanOptions("CombineCore");
89-
#endif
9085
}
9186
TString GetFixedQuery() const {
9287
TStringBuilder queryFixed;
@@ -177,7 +172,8 @@ void CheckPlanForAggregatePushdown(
177172
const TString& query,
178173
TClient& client,
179174
const std::vector<std::string>& expectedPlanNodes,
180-
const std::string& readNodeType) {
175+
const std::string& readNodeType)
176+
{
181177
auto res = StreamExplainQuery(query, client);
182178
UNIT_ASSERT_C(res.IsSuccess(), res.GetIssues().ToString());
183179

@@ -242,4 +238,4 @@ void WriteTestDataForTableWithNulls(TKikimrRunner& kikimr, TString testTable);
242238

243239
void TestTableWithNulls(const std::vector<TAggregationTestCase>& cases, const bool genericQuery = false);
244240

245-
}
241+
}

ydb/core/kqp/ut/olap/kqp_olap_ut.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -2485,7 +2485,7 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
24852485
UNIT_ASSERT_C(result.GetStatus() == NYdb::EStatus::SUCCESS, result.GetIssues().ToString());
24862486

24872487
auto client = kikimr.GetQueryClient();
2488-
{
2488+
{
24892489
auto prepareResult = client.ExecuteQuery(R"(
24902490
REPLACE INTO `/Root/ColumnShard` (a, b, c) VALUES
24912491
(1u, 1, 5),
@@ -2515,15 +2515,15 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
25152515
UNIT_ASSERT_C(plan.QueryStats->Getquery_ast().Contains("return (FromFlow (NarrowMap (WideFromBlocks"), plan.QueryStats->Getquery_ast());
25162516
break;
25172517
case NKikimrConfig::TTableServiceConfig_EBlockChannelsMode_BLOCK_CHANNELS_AUTO:
2518-
UNIT_ASSERT_C(plan.QueryStats->Getquery_ast().Contains("return (FromFlow (ExpandMap (NarrowMap (WideFromBlocks"), plan.QueryStats->Getquery_ast());
2518+
UNIT_ASSERT_C(plan.QueryStats->Getquery_ast().Contains("return (FromFlow (WideFromBlocks"), plan.QueryStats->Getquery_ast());
25192519
break;
25202520
case NKikimrConfig::TTableServiceConfig_EBlockChannelsMode_BLOCK_CHANNELS_FORCE:
25212521
UNIT_ASSERT_C(plan.QueryStats->Getquery_ast().Contains("return (FromFlow (WideMap"), plan.QueryStats->Getquery_ast());
25222522
break;
25232523
}
25242524
}
25252525

2526-
{
2526+
{
25272527
auto it = client.StreamExecuteQuery(R"(
25282528
SELECT
25292529
b, COUNT(*), SUM(a)

0 commit comments

Comments
 (0)