tests/library/harness: get rid of warnings on unclosed files

Author: ijon

ydb/tests/library/harness/daemon.py

@@ -62,6 +62,7 @@ def __init__(
         stderr_file="/dev/null",
         stderr_on_error_lines=0,
         core_pattern=None,
+        templog_file=None
     ):
         self.__cwd = cwd
         self.__timeout = timeout
@@ -73,6 +74,7 @@ def __init__(
         self.logger = logger.getChild(self.__class__.__name__)
         self.__stdout_file = open(stdout_file, mode='wb')
         self.__stderr_file = open(stderr_file, mode='wb')
+        self.__templog_file = templog_file
 
     @property
     def daemon(self):
@@ -92,6 +94,12 @@ def stderr_file_name(self):
         else:
             return None
 
+    def __close_open_files(self):
+        self.__stdout_file.close()
+        self.__stderr_file.close()
+        if self.__templog_file is not None:
+            self.__templog_file.close()
+
     def is_alive(self):
         return self.__daemon is not None and self.__daemon.running
 
@@ -112,6 +120,7 @@ def start(self):
 
         if not self.is_alive():
             self.__check_before_fail()
+            self.__close_open_files()
             raise DaemonError(
                 "Unexpectedly finished on start",
                 exit_code=self.__daemon.exit_code,
@@ -162,6 +171,8 @@ def __check_before_end_stop(self, stop_type):
                 stderr=self.stderr_file_name,
                 max_stderr_lines=self.__stderr_on_error_lines,
             )
+        else:
+            self.__close_open_files()
 
     def stop(self):
         if not self.__check_can_launch_stop("stop"):

ydb/tests/library/harness/kikimr_runner.py

@@ -89,10 +89,11 @@ def __init__(self, node_id, config_path, port_allocator, cluster_name, configura
         )
 
         if configurator.use_log_files:
-            self.__log_file = tempfile.NamedTemporaryFile(dir=self.__working_dir, prefix="logfile_", suffix=".log", delete=False)
+            self.__log_file = tempfile.NamedTemporaryFile(dir=self.__working_dir, prefix="logfile_", suffix=".log", delete=False, delete_on_close=False)
             kwargs = {
                 "stdout_file": os.path.join(self.__working_dir, "stdout"),
-                "stderr_file": os.path.join(self.__working_dir, "stderr")
+                "stderr_file": os.path.join(self.__working_dir, "stderr"),
+                "templog_file": self.__log_file,
                 }
         else:
             self.__log_file = None