Skip to content

Commit 89bfbfd

Browse files
authored
fix partition counter value (#3587)
1 parent d39295a commit 89bfbfd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

ydb/core/persqueue/partition.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ TString TPartition::LogPrefix() const {
8787

8888
bool TPartition::CanWrite() const {
8989
if (PartitionConfig == nullptr) {
90-
// Old format without AllPartitions configuration field.
90+
// Old format without AllPartitions configuration field.
9191
// It is not split/merge partition.
9292
return true;
9393
}
@@ -273,7 +273,7 @@ ui64 TPartition::ImportantClientsMinOffset() const {
273273
minOffset = Min<ui64>(minOffset, curOffset);
274274
}
275275

276-
return minOffset;
276+
return minOffset;
277277
}
278278

279279
void TPartition::HandleWakeup(const TActorContext& ctx) {
@@ -552,7 +552,7 @@ void TPartition::InitComplete(const TActorContext& ctx) {
552552
PartitionCountersLabeled->GetCounters()[METRIC_INIT_TIME] = InitDuration.MilliSeconds();
553553
PartitionCountersLabeled->GetCounters()[METRIC_LIFE_TIME] = CreationTime.MilliSeconds();
554554
PartitionCountersLabeled->GetCounters()[METRIC_PARTITIONS] = 1;
555-
PartitionCountersLabeled->GetCounters()[METRIC_PARTITIONS_TOTAL] = Config.PartitionIdsSize();
555+
PartitionCountersLabeled->GetCounters()[METRIC_PARTITIONS_TOTAL] = std::max(Config.PartitionIdsSize(), Config.PartitionsSize());
556556
ctx.Send(Tablet, new TEvPQ::TEvPartitionLabeledCounters(Partition, *PartitionCountersLabeled));
557557
}
558558
UpdateUserInfoEndOffset(ctx.Now());
@@ -969,7 +969,7 @@ void TPartition::Handle(TEvPQ::TEvBlobResponse::TPtr& ev, const TActorContext& c
969969

970970
auto it = ReadInfo.find(cookie);
971971
Y_ABORT_UNLESS(it != ReadInfo.end());
972-
972+
973973
TReadInfo info = std::move(it->second);
974974
ReadInfo.erase(it);
975975

@@ -980,7 +980,7 @@ void TPartition::Handle(TEvPQ::TEvBlobResponse::TPtr& ev, const TActorContext& c
980980
info.Destination, GetSizeLag(info.Offset), Tablet, Config.GetMeteringMode()
981981
));
982982
const auto& resp = dynamic_cast<TEvPQ::TEvProxyResponse*>(answer.Event.Get())->Response;
983-
983+
984984
if (HasError(*ev->Get())) {
985985
if (info.IsSubscription) {
986986
TabletCounters.Cumulative()[COUNTER_PQ_READ_SUBSCRIPTION_ERROR].Increment(1);

0 commit comments

Comments
 (0)