Skip to content

Commit 91e6984

Browse files
authored
Merge bebab98 into 5ef387d
2 parents 5ef387d + bebab98 commit 91e6984

20 files changed

+2951
-193
lines changed

.gitignore

+6
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
!*/
88
# Unignore all files inside canondata dir
99
!**/canondata/**
10+
# Allow docker files
11+
!Dockerfile
1012

1113
/canonization_show_res.log
1214

@@ -43,6 +45,7 @@ __pycache__/
4345
.idea/
4446
.vscode/
4547
.clangd
48+
.antlr/
4649

4750
# KDevelop IDE
4851
*.kdev4
@@ -82,3 +85,6 @@ list_result.log
8285
bin/config.json
8386

8487
.vs/
88+
89+
# handy for local junk, which is not intended to appear in the repo
90+
junk/

ydb/core/driver_lib/run/kikimr_services_initializers.cpp

+2-4
Original file line numberDiff line numberDiff line change
@@ -1173,6 +1173,8 @@ void TSharedCacheInitializer::InitializeServices(
11731173

11741174
config->TotalAsyncQueueInFlyLimit = cfg.GetAsyncQueueInFlyLimit();
11751175
config->TotalScanQueueInFlyLimit = cfg.GetScanQueueInFlyLimit();
1176+
config->ReplacementPolicy = cfg.GetReplacementPolicy();
1177+
config->LimitBytes = cfg.GetMemoryLimit();
11761178

11771179
if (cfg.HasActivePagesReservationPercent()) {
11781180
config->ActivePagesReservationPercent = cfg.GetActivePagesReservationPercent();
@@ -1184,10 +1186,6 @@ void TSharedCacheInitializer::InitializeServices(
11841186
TIntrusivePtr<::NMonitoring::TDynamicCounters> tabletGroup = GetServiceCounters(appData->Counters, "tablets");
11851187
TIntrusivePtr<::NMonitoring::TDynamicCounters> sausageGroup = tabletGroup->GetSubgroup("type", "S_CACHE");
11861188

1187-
config->CacheConfig = new TCacheCacheConfig(cfg.GetMemoryLimit(),
1188-
sausageGroup->GetCounter("fresh"),
1189-
sausageGroup->GetCounter("staging"),
1190-
sausageGroup->GetCounter("warm"));
11911189
config->Counters = new TSharedPageCacheCounters(sausageGroup);
11921190

11931191
setup->LocalServices.push_back(std::pair<TActorId, TActorSetupCmd>(MakeSharedPageCacheId(0),

ydb/core/protos/shared_cache.proto

+8
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
11
package NKikimrSharedCache;
22
option java_package = "ru.yandex.kikimr.proto";
33

4+
enum TReplacementPolicy {
5+
ThreeLeveledLRU = 0;
6+
S3FIFO = 1;
7+
ClockPro = 2;
8+
}
9+
410
message TSharedCacheConfig {
511
optional uint64 MemoryLimit = 1 [default = 536870912];
612
optional uint64 ScanQueueInFlyLimit = 2 [default = 536870912];
713
optional uint64 AsyncQueueInFlyLimit = 3 [default = 536870912];
814
optional uint32 ActivePagesReservationPercent = 4;
915
optional uint32 MemTableReservationPercent = 5;
16+
optional TReplacementPolicy ReplacementPolicy = 6 [default = ThreeLeveledLRU];
17+
reserved 7;
1018
}

ydb/core/protos/ya.make

+1
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ SRCS(
149149

150150
GENERATE_ENUM_SERIALIZATION(blobstorage_pdisk_config.pb.h)
151151
GENERATE_ENUM_SERIALIZATION(datashard_load.pb.h)
152+
GENERATE_ENUM_SERIALIZATION(shared_cache.pb.h)
152153

153154
PEERDIR(
154155
ydb/library/actors/protos

0 commit comments

Comments
 (0)