Skip to content

Commit 9bf348b

Browse files
authored
YQL-17542 split stat (#1553)
1 parent a7a2a17 commit 9bf348b

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

ydb/library/yql/dq/actors/compute/dq_async_compute_actor.cpp

+5
Original file line numberDiff line numberDiff line change
@@ -789,6 +789,11 @@ class TDqAsyncComputeActor : public TDqComputeActorBase<TDqAsyncComputeActor, TC
789789
return TaskRunnerStats.Get();
790790
}
791791

792+
const NYql::NDq::TDqMeteringStats* GetMeteringStats() override {
793+
// TODO: support async CA
794+
return nullptr;
795+
}
796+
792797
template<typename TSecond>
793798
TVector<ui32> GetIds(const THashMap<ui64, TSecond>& collection) {
794799
TVector<ui32> ids;

ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h

+4-7
Original file line numberDiff line numberDiff line change
@@ -1758,9 +1758,8 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
17581758
}
17591759
}
17601760

1761-
virtual const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() {
1762-
return TaskRunner ? TaskRunner->GetStats() : nullptr;
1763-
}
1761+
virtual const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() = 0;
1762+
virtual const NYql::NDq::TDqMeteringStats* GetMeteringStats() = 0;
17641763

17651764
virtual const IDqAsyncOutputBuffer* GetSink(ui64, const TAsyncOutputInfoBase& sinkInfo) const {
17661765
return sinkInfo.Buffer.Get();
@@ -1820,8 +1819,7 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
18201819

18211820
for (auto& [inputIndex, sourceInfo] : SourcesMap) {
18221821
if (auto* source = sourceInfo.AsyncInput) {
1823-
// TODO: support async CA
1824-
source->FillExtraStats(protoTask, last, TaskRunner ? TaskRunner->GetMeteringStats() : nullptr);
1822+
source->FillExtraStats(protoTask, last, GetMeteringStats());
18251823
}
18261824
}
18271825
FillTaskRunnerStats(Task.GetId(), Task.GetStageId(), *taskStats, protoTask, RuntimeSettings.GetCollectStatsLevel());
@@ -1926,8 +1924,7 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
19261924
}
19271925

19281926
if (auto* transform = transformInfo.AsyncInput) {
1929-
// TODO: support async CA
1930-
transform->FillExtraStats(protoTask, last, TaskRunner ? TaskRunner->GetMeteringStats() : 0);
1927+
transform->FillExtraStats(protoTask, last, GetMeteringStats());
19311928
}
19321929
}
19331930

ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h

+8
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,14 @@ class TDqSyncComputeActorBase: public TDqComputeActorBase<TDerived, TComputeActo
123123
this->TaskRunner->GetRandomProvider()
124124
);
125125
}
126+
127+
const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() override {
128+
return this->TaskRunner ? this->TaskRunner->GetStats() : nullptr;
129+
}
130+
131+
const NYql::NDq::TDqMeteringStats* GetMeteringStats() override {
132+
return this->TaskRunner ? this->TaskRunner->GetMeteringStats() : nullptr;
133+
}
126134
};
127135

128136
} //namespace NYql::NDq

0 commit comments

Comments
 (0)