YT-20113: Fix comparision of doubles when nans are present.

0adadb02b41252223fd3101d25ecbc969d523131

Author: yuryalekseev

yt/yt/client/table_client/composite_compare.cpp

@@ -215,6 +215,25 @@ i64 GetMinResultingSize(const TYsonItem& item, bool isInsideList)
 
 } // namespace
 
+int CompareDoubleValues(double lhs, double rhs)
+{
+    if (lhs < rhs) {
+        return -1;
+    } else if (lhs > rhs) {
+        return +1;
+    } else if (std::isnan(lhs)) {
+        if (std::isnan(rhs)) {
+            return 0;
+        } else {
+            return 1;
+        }
+    } else if (std::isnan(rhs)) {
+        return -1;
+    }
+
+    return 0;
+}
+
 int CompareYsonValues(TYsonStringBuf lhs, TYsonStringBuf rhs)
 {
     YT_ASSERT(lhs.GetType() == EYsonType::Node);

yt/yt/client/table_client/composite_compare.h

@@ -10,6 +10,7 @@ namespace NYT::NTableClient {
 
 ////////////////////////////////////////////////////////////////////////////////
 
+int CompareDoubleValues(double lhs, double rhs);
 int CompareYsonValues(NYson::TYsonStringBuf lhs, NYson::TYsonStringBuf rhs);
 TFingerprint CompositeFarmHash(NYson::TYsonStringBuf compositeValue);
 

yt/yt/client/table_client/unversioned_row.cpp

@@ -395,23 +395,7 @@ int CompareRowValues(const TUnversionedValue& lhs, const TUnversionedValue& rhs)
         }
 
         case EValueType::Double: {
-            double lhsValue = lhs.Data.Double;
-            double rhsValue = rhs.Data.Double;
-            if (lhsValue < rhsValue) {
-                return -1;
-            } else if (lhsValue > rhsValue) {
-                return +1;
-            } else if (std::isnan(lhsValue)) {
-                if (std::isnan(rhsValue)) {
-                    return 0;
-                } else {
-                    return 1;
-                }
-            } else if (std::isnan(rhsValue)) {
-                return -1;
-            } else {
-                return 0;
-            }
+            return CompareDoubleValues(lhs.Data.Double, rhs.Data.Double);
         }
 
         case EValueType::Boolean: {