Skip to content

Commit a63de6a

Browse files
committed
fix after rebase
1 parent 3326085 commit a63de6a

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

ydb/apps/pgwire/pg_ydb_connection.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ class TPgYdbConnection : public TActorBootstrapped<TPgYdbConnection> {
127127
}
128128

129129
{
130-
NYdb::TResultSetParser parser(std::move(resultSet));
130+
TResultSetParser parser(std::move(resultSet));
131131
while (parser.TryNextRow()) {
132132
response->DataRows.emplace_back();
133133
auto& row = response->DataRows.back();
@@ -387,7 +387,7 @@ class TPgYdbConnection : public TActorBootstrapped<TPgYdbConnection> {
387387

388388
{
389389
auto maxRows = ev->Get()->Message->GetExecuteData().MaxRows;
390-
NYdb::TResultSetParser parser(std::move(resultSet));
390+
TResultSetParser parser(std::move(resultSet));
391391
while (parser.TryNextRow()) {
392392
response->DataRows.emplace_back();
393393
auto& row = response->DataRows.back();

ydb/core/kafka_proxy/actors/kafka_balancer_actor.cpp

+9-10
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,7 @@ void TKafkaBalancerActor::Handle(NKqp::TEvKqp::TEvQueryResponse::TPtr& ev, const
9393

9494
NYql::TIssues issues;
9595
NYql::IssuesFromMessage(record.GetResponse().GetQueryIssues(), issues);
96-
NYdb::TStatus status(NYdb::EStatus(record.GetYdbStatus()), std::move(issues));
97-
kqpQueryError << status;
96+
kqpQueryError << issues.ToString();
9897

9998
SendResponseFail(ctx, kafkaErr, kqpQueryError);
10099
}
@@ -165,11 +164,11 @@ std::optional<TGroupStatus> TKafkaBalancerActor::ParseCheckStateAndGeneration(
165164
return result;
166165
}
167166

168-
result.State = parser.ColumnParser("state").GetOptionalUint64().GetOrElse(0);
169-
result.Generation = parser.ColumnParser("generation").GetOptionalUint64().GetOrElse(0);
170-
result.MasterId = parser.ColumnParser("master").GetOptionalUtf8().GetOrElse("");
171-
result.LastHeartbeat = parser.ColumnParser("last_heartbeat_time").GetOptionalDatetime().GetOrElse(TInstant::Zero());
172-
result.ProtocolName = parser.ColumnParser("protocol").GetOptionalUtf8().GetOrElse("");
167+
result.State = parser.ColumnParser("state").GetOptionalUint64().value_or(0);
168+
result.Generation = parser.ColumnParser("generation").GetOptionalUint64().value_or(0);
169+
result.MasterId = parser.ColumnParser("master").GetOptionalUtf8().value_or("");
170+
result.LastHeartbeat = parser.ColumnParser("last_heartbeat_time").GetOptionalDatetime().value_or(TInstant::Zero());
171+
result.ProtocolName = parser.ColumnParser("protocol").GetOptionalUtf8().value_or("");
173172
result.Exists = true;
174173

175174
if (parser.TryNextRow()) {
@@ -199,7 +198,7 @@ bool TKafkaBalancerActor::ParseAssignments(
199198
return false;
200199
}
201200

202-
assignments = parser.ColumnParser("assignment").GetOptionalString().GetOrElse("");
201+
assignments = parser.ColumnParser("assignment").GetOptionalString().value_or("");
203202

204203
if (parser.TryNextRow()) {
205204
return false;
@@ -232,8 +231,8 @@ bool TKafkaBalancerActor::ParseWorkerStatesAndChooseProtocol(
232231

233232
std::vector<TParsedState> states;
234233
while (parser.TryNextRow()) {
235-
TString protoStr = parser.ColumnParser("worker_state_proto").GetOptionalString().GetOrElse("");
236-
TString memberId = parser.ColumnParser("member_id").GetOptionalUtf8().GetOrElse("");
234+
TString protoStr = parser.ColumnParser("worker_state_proto").GetOptionalString().value_or("");
235+
TString memberId = parser.ColumnParser("member_id").GetOptionalUtf8().value_or("");
237236

238237
NKafka::TWorkerState workerState;
239238
if (!protoStr.empty() && !workerState.ParseFromString(protoStr)) {

0 commit comments

Comments
 (0)