Skip to content

Commit ac7d33d

Browse files
committed
Set pointer as nullptr after free memory
1 parent 2e0d841 commit ac7d33d

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

ydb/core/security/ldap_auth_provider/ldap_auth_provider.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,7 @@ class TLdapAuthProvider : public NActors::TActorBootstrapped<TLdapAuthProvider>
322322
response.Error = {.Message = ERROR_MESSAGE, .LogMessage = logErrorMessage, .Retryable = NKikimrLdap::IsRetryableError(result)};
323323
LDAP_LOG_D(logErrorMessage);
324324
NKikimrLdap::MsgFree(searchMessage);
325+
searchMessage = nullptr;
325326
return response;
326327
}
327328
const int countEntries = NKikimrLdap::CountEntries(request.Ld, searchMessage);
@@ -337,6 +338,7 @@ class TLdapAuthProvider : public NActors::TActorBootstrapped<TLdapAuthProvider>
337338
response.Error = {.Message = ERROR_MESSAGE, .LogMessage = logErrorMessage, .Retryable = false};
338339
response.Status = TEvLdapAuthProvider::EStatus::UNAUTHORIZED;
339340
NKikimrLdap::MsgFree(searchMessage);
341+
searchMessage = nullptr;
340342
LDAP_LOG_D(logErrorMessage);
341343
return response;
342344
}
@@ -359,11 +361,13 @@ class TLdapAuthProvider : public NActors::TActorBootstrapped<TLdapAuthProvider>
359361
int result = NKikimrLdap::Search(ld, Settings.GetBaseDn(), NKikimrLdap::EScope::SUBTREE, filter, NKikimrLdap::noAttributes, 0, &searchMessage);
360362
if (!NKikimrLdap::IsSuccess(result)) {
361363
NKikimrLdap::MsgFree(searchMessage);
364+
searchMessage = nullptr;
362365
return {};
363366
}
364367
const int countEntries = NKikimrLdap::CountEntries(ld, searchMessage);
365368
if (countEntries == 0) {
366369
NKikimrLdap::MsgFree(searchMessage);
370+
searchMessage = nullptr;
367371
return {};
368372
}
369373
std::vector<TString> groups;
@@ -375,6 +379,7 @@ class TLdapAuthProvider : public NActors::TActorBootstrapped<TLdapAuthProvider>
375379
dn = nullptr;
376380
}
377381
NKikimrLdap::MsgFree(searchMessage);
382+
searchMessage = nullptr;
378383
return groups;
379384
}
380385

@@ -406,10 +411,12 @@ class TLdapAuthProvider : public NActors::TActorBootstrapped<TLdapAuthProvider>
406411
int result = NKikimrLdap::Search(ld, Settings.GetBaseDn(), NKikimrLdap::EScope::SUBTREE, filter, RequestedAttributes, 0, &searchMessage);
407412
if (!NKikimrLdap::IsSuccess(result)) {
408413
NKikimrLdap::MsgFree(searchMessage);
414+
searchMessage = nullptr;
409415
return;
410416
}
411417
if (NKikimrLdap::CountEntries(ld, searchMessage) == 0) {
412418
NKikimrLdap::MsgFree(searchMessage);
419+
searchMessage = nullptr;
413420
return;
414421
}
415422
for (LDAPMessage* groupEntry = NKikimrLdap::FirstEntry(ld, searchMessage); groupEntry != nullptr; groupEntry = NKikimrLdap::NextEntry(ld, groupEntry)) {
@@ -432,6 +439,7 @@ class TLdapAuthProvider : public NActors::TActorBootstrapped<TLdapAuthProvider>
432439
}
433440
}
434441
NKikimrLdap::MsgFree(searchMessage);
442+
searchMessage = nullptr;
435443
}
436444
}
437445

0 commit comments

Comments
 (0)