Health check for exclusive dynamic nodes KIKIMR-20818 (#1223)

* Health check for exclusive dynamic nodes KIKIMR-20818

Author: pixcc

ydb/core/health_check/health_check.cpp

@@ -228,12 +228,13 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
         TTabletId HiveId = {};
         TPathId ResourcePathId = {};
         TVector<TNodeId> ComputeNodeIds;
-        TVector<TString> StoragePoolNames;
+        THashSet<TString> StoragePoolNames;
         THashMap<std::pair<TTabletId, NNodeWhiteboard::TFollowerId>, const NKikimrHive::TTabletInfo*> MergedTabletState;
         THashMap<TNodeId, TNodeTabletState> MergedNodeTabletState;
         THashMap<TNodeId, ui32> NodeRestartsPerPeriod;
         ui64 StorageQuota;
         ui64 StorageUsage;
+        TMaybeServerlessComputeResourcesMode ServerlessComputeResourcesMode;
     };
 
     struct TSelfCheckResult {
@@ -514,7 +515,7 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
     TDuration Timeout = TDuration::MilliSeconds(20000);
     static constexpr TStringBuf STATIC_STORAGE_POOL_NAME = "static";
 
-    bool IsSpecificDatabaseFilter() {
+    bool IsSpecificDatabaseFilter() const {
         return FilterDatabase && FilterDatabase != DomainPath;
     }
 
@@ -593,7 +594,7 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
                     StoragePoolState[storagePoolName].Groups.emplace(group.groupid());
 
                     if (!IsSpecificDatabaseFilter()) {
-                        DatabaseState[DomainPath].StoragePoolNames.emplace_back(storagePoolName);
+                        DatabaseState[DomainPath].StoragePoolNames.emplace(storagePoolName);
                     }
                 }
             }
@@ -869,12 +870,12 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
             TDatabaseState& state(DatabaseState[path]);
             for (const auto& storagePool : ev->Get()->GetRecord().pathdescription().domaindescription().storagepools()) {
                 TString storagePoolName = storagePool.name();
-                state.StoragePoolNames.emplace_back(storagePoolName);
+                state.StoragePoolNames.emplace(storagePoolName);
                 StoragePoolState[storagePoolName].Kind = storagePool.kind();
                 RequestSelectGroups(storagePoolName);
             }
             if (path == DomainPath) {
-                state.StoragePoolNames.emplace_back(STATIC_STORAGE_POOL_NAME);
+                state.StoragePoolNames.emplace(STATIC_STORAGE_POOL_NAME);
             }
             state.StorageUsage = ev->Get()->GetRecord().pathdescription().domaindescription().diskspaceusage().tables().totalsize();
             state.StorageQuota = ev->Get()->GetRecord().pathdescription().domaindescription().databasequotas().data_size_hard_quota();
@@ -888,12 +889,19 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
         if (ev->Get()->Request->ResultSet.size() == 1 && ev->Get()->Request->ResultSet.begin()->Status == NSchemeCache::TSchemeCacheNavigate::EStatus::Ok) {
             auto domainInfo = ev->Get()->Request->ResultSet.begin()->DomainInfo;
             TString path = CanonizePath(ev->Get()->Request->ResultSet.begin()->Path);
-
-            if (domainInfo->DomainKey != domainInfo->ResourcesDomainKey) {
-                if (SharedDatabases.emplace(domainInfo->ResourcesDomainKey, path).second) {
-                    RequestSchemeCacheNavigate(domainInfo->ResourcesDomainKey);
+            if (domainInfo->IsServerless()) {
+                if (NeedHealthCheckForServerless(domainInfo)) {
+                    if (SharedDatabases.emplace(domainInfo->ResourcesDomainKey, path).second) {
+                        RequestSchemeCacheNavigate(domainInfo->ResourcesDomainKey);
+                    }
+                    DatabaseState[path].ResourcePathId = domainInfo->ResourcesDomainKey;
+                    DatabaseState[path].ServerlessComputeResourcesMode = domainInfo->ServerlessComputeResourcesMode;
+                } else {
+                    DatabaseState.erase(path);
+                    DatabaseStatusByPath.erase(path);
+                    RequestDone("TEvNavigateKeySetResult");
+                    return;
                 }
-                DatabaseState[path].ResourcePathId = domainInfo->ResourcesDomainKey;
             }
             TTabletId hiveId = domainInfo->Params.GetHive();
             if (hiveId) {
@@ -918,6 +926,11 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
         RequestDone("TEvNavigateKeySetResult");
     }
 
+    bool NeedHealthCheckForServerless(TIntrusivePtr<NSchemeCache::TDomainInfo> domainInfo) const {
+        return IsSpecificDatabaseFilter()
+            || domainInfo->ServerlessComputeResourcesMode == NKikimrSubDomains::EServerlessComputeResourcesModeExclusive;
+    }
+
     void Handle(TEvHive::TEvResponseHiveDomainStats::TPtr& ev) {
         TTabletId hiveId = TabletRequests.CompleteRequest(ev->Cookie);
         for (const NKikimrHive::THiveDomainStats& hiveStat : ev->Get()->Record.GetDomainStats()) {
@@ -951,15 +964,9 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
             Ydb::Cms::GetDatabaseStatusResult getTenantStatusResult;
             operation.result().UnpackTo(&getTenantStatusResult);
             TString path = getTenantStatusResult.path();
-
-            bool ignoreServerlessDatabases = !IsSpecificDatabaseFilter(); // we don't ignore sl database if it was exactly specified
-            if (getTenantStatusResult.has_serverless_resources() && ignoreServerlessDatabases) {
-                DatabaseState.erase(path);
-            } else {
-                DatabaseStatusByPath[path] = std::move(getTenantStatusResult);
-                DatabaseState[path];
-                RequestSchemeCacheNavigate(path);
-            }
+            DatabaseStatusByPath[path] = std::move(getTenantStatusResult);
+            DatabaseState[path];
+            RequestSchemeCacheNavigate(path);
         }
         RequestDone("TEvGetTenantStatusResponse");
     }
@@ -1298,7 +1305,9 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
 
     void FillCompute(TDatabaseState& databaseState, Ydb::Monitoring::ComputeStatus& computeStatus, TSelfCheckContext context) {
         TVector<TNodeId>* computeNodeIds = &databaseState.ComputeNodeIds;
-        if (databaseState.ResourcePathId) {
+        if (databaseState.ResourcePathId 
+            && databaseState.ServerlessComputeResourcesMode != NKikimrSubDomains::EServerlessComputeResourcesModeExclusive) 
+        {
             auto itDatabase = FilterDomainKey.find(TSubDomainKey(databaseState.ResourcePathId.OwnerId, databaseState.ResourcePathId.LocalPathId));
             if (itDatabase != FilterDomainKey.end()) {
                 const TString& sharedDatabaseName = itDatabase->second;
@@ -2124,7 +2133,7 @@ class TSelfCheckRequest : public TActorBootstrapped<TSelfCheckRequest> {
             TDatabaseState unknownDatabase;
             for (auto& [name, pool] : StoragePoolState) {
                 if (StoragePoolSeen.count(name) == 0) {
-                    unknownDatabase.StoragePoolNames.push_back(name);
+                    unknownDatabase.StoragePoolNames.insert(name);
                 }
             }
             if (!unknownDatabase.StoragePoolNames.empty()) {