Skip to content

Commit ae7d808

Browse files
committed
Refine comments
1 parent aaa6da8 commit ae7d808

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

ydb/library/yql/dq/actors/compute/dq_async_compute_actor.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -847,7 +847,10 @@ class TDqAsyncComputeActor : public TDqComputeActorBase<TDqAsyncComputeActor, TC
847847
auto it = OutputChannelsMap.find(ev->Get()->ChannelId);
848848
Y_ABORT_UNLESS(it != OutputChannelsMap.end());
849849
TOutputChannelInfo& outputChannel = it->second;
850-
if (!Channels->ShouldSkipData(outputChannel.ChannelId) && !Channels->CanSendChannelData(outputChannel.ChannelId)) { // When channel will be connected (or finish retrying), they will call resume execution.
850+
// This condition was already checked in ProcessOutputsImpl, but since then
851+
// RetryState could've been changed. Recheck it once again:
852+
if (!Channels->ShouldSkipData(outputChannel.ChannelId) && !Channels->CanSendChannelData(outputChannel.ChannelId)) {
853+
// Once RetryState will be reset, channel will trigger either ResumeExecution or PeerFinished; either way execution will re-reach this function
851854
CA_LOG_D("OnOutputChannelData return because Channel can't send channel data, channel: " << outputChannel.ChannelId);
852855
return;
853856
}

0 commit comments

Comments
 (0)