throttling: use device speed from pdisk cost model (#14452)

Author: alexd65536

ydb/core/blobstorage/nodewarden/node_warden_impl.cpp

@@ -31,7 +31,6 @@ TNodeWarden::TNodeWarden(const TIntrusivePtr<TNodeWardenConfig> &cfg)
     , DefaultHugeGarbagePerMille(300, 1, 1000)
     , HugeDefragFreeSpaceBorderPerMille(260, 1, 1000)
     , MaxChunksToDefragInflight(10, 1, 50)
-    , ThrottlingDeviceSpeed(50 << 20, 1 << 20, 10ull << 30)
     , ThrottlingDryRun(1, 0, 1)
     , ThrottlingMinLevel0SstCount(100, 1, 1000)
     , ThrottlingMaxLevel0SstCount(250, 1, 1000)
@@ -355,7 +354,6 @@ void TNodeWarden::Bootstrap() {
         icb->RegisterSharedControl(HugeDefragFreeSpaceBorderPerMille, "VDiskControls.HugeDefragFreeSpaceBorderPerMille");
         icb->RegisterSharedControl(MaxChunksToDefragInflight, "VDiskControls.MaxChunksToDefragInflight");
 
-        icb->RegisterSharedControl(ThrottlingDeviceSpeed, "VDiskControls.ThrottlingDeviceSpeed");
         icb->RegisterSharedControl(ThrottlingDryRun, "VDiskControls.ThrottlingDryRun");
         icb->RegisterSharedControl(ThrottlingMinLevel0SstCount, "VDiskControls.ThrottlingMinLevel0SstCount");
         icb->RegisterSharedControl(ThrottlingMaxLevel0SstCount, "VDiskControls.ThrottlingMaxLevel0SstCount");

ydb/core/blobstorage/nodewarden/node_warden_impl.h

@@ -180,7 +180,6 @@ namespace NKikimr::NStorage {
         TControlWrapper HugeDefragFreeSpaceBorderPerMille;
         TControlWrapper MaxChunksToDefragInflight;
 
-        TControlWrapper ThrottlingDeviceSpeed;
         TControlWrapper ThrottlingDryRun;
         TControlWrapper ThrottlingMinLevel0SstCount;
         TControlWrapper ThrottlingMaxLevel0SstCount;

ydb/core/blobstorage/nodewarden/node_warden_vdisk.cpp

@@ -200,7 +200,6 @@ namespace NKikimr::NStorage {
             vdiskConfig->MaxSyncLogChunksInFlight = MaxSyncLogChunksInFlightSSD;
         }
 
-        vdiskConfig->ThrottlingDeviceSpeed = ThrottlingDeviceSpeed;
         vdiskConfig->ThrottlingDryRun = ThrottlingDryRun;
         vdiskConfig->ThrottlingMinLevel0SstCount = ThrottlingMinLevel0SstCount;
         vdiskConfig->ThrottlingMaxLevel0SstCount = ThrottlingMaxLevel0SstCount;

ydb/core/blobstorage/vdisk/common/vdisk_config.h

@@ -246,7 +246,6 @@ namespace NKikimr {
         TCostMetricsParametersByMedia CostMetricsParametersByMedia;
 
         ///////////// THROTTLING SETTINGS //////////////////
-        TControlWrapper ThrottlingDeviceSpeed;
         TControlWrapper ThrottlingDryRun;
         TControlWrapper ThrottlingMinLevel0SstCount;
         TControlWrapper ThrottlingMaxLevel0SstCount;

ydb/core/blobstorage/vdisk/skeleton/skeleton_overload_handler.cpp

@@ -184,6 +184,8 @@ namespace NKikimr {
         TIntrusivePtr<TVDiskConfig> VCfg;
         TPDiskCtxPtr PDiskCtx;
 
+        ui64 WriteSpeedBps = 100'000'000;
+
         TControlWrapper ThrottlingMinInplacedSize;
         TControlWrapper ThrottlingMaxInplacedSize;
 
@@ -211,35 +213,31 @@ namespace NKikimr {
         }
 
         ui64 CalcSstCountSpeedLimit() const {
-            ui64 deviceSpeed = (ui64)VCfg->ThrottlingDeviceSpeed;
             ui64 minSstCount = (ui64)VCfg->ThrottlingMinLevel0SstCount;
             ui64 maxSstCount = (ui64)VCfg->ThrottlingMaxLevel0SstCount;
 
-            return LinearInterpolation(CurrentSstCount, minSstCount, maxSstCount, deviceSpeed);
+            return LinearInterpolation(CurrentSstCount, minSstCount, maxSstCount, WriteSpeedBps);
         }
 
         ui64 CalcInplacedSizeSpeedLimit() const {
-            ui64 deviceSpeed = (ui64)VCfg->ThrottlingDeviceSpeed;
             ui64 minInplacedSize = (ui64)ThrottlingMinInplacedSize;
             ui64 maxInplacedSize = (ui64)ThrottlingMaxInplacedSize;
 
-            return LinearInterpolation(CurrentInplacedSize, minInplacedSize, maxInplacedSize, deviceSpeed);
+            return LinearInterpolation(CurrentInplacedSize, minInplacedSize, maxInplacedSize, WriteSpeedBps);
         }
 
         ui64 CalcOccupancySpeedLimit() const {
-            ui64 deviceSpeed = (ui64)VCfg->ThrottlingDeviceSpeed;
             ui64 minOccupancy = (ui64)VCfg->ThrottlingMinOccupancyPerMille * 1000;
             ui64 maxOccupancy = (ui64)VCfg->ThrottlingMaxOccupancyPerMille * 1000;
 
-            return LinearInterpolation(CurrentOccupancy, minOccupancy, maxOccupancy, deviceSpeed);
+            return LinearInterpolation(CurrentOccupancy, minOccupancy, maxOccupancy, WriteSpeedBps);
         }
 
         ui64 CalcLogChunkCountSpeedLimit() const {
-            ui64 deviceSpeed = (ui64)VCfg->ThrottlingDeviceSpeed;
             ui64 minLogChunkCount = (ui64)VCfg->ThrottlingMinLogChunkCount;
             ui64 maxLogChunkCount = (ui64)VCfg->ThrottlingMaxLogChunkCount;
 
-            return LinearInterpolation(CurrentLogChunkCount, minLogChunkCount, maxLogChunkCount, deviceSpeed);
+            return LinearInterpolation(CurrentLogChunkCount, minLogChunkCount, maxLogChunkCount, WriteSpeedBps);
         }
 
         ui64 CalcSpeedLimit() const {
@@ -267,6 +265,7 @@ namespace NKikimr {
             NPDisk::EDeviceType mediaType = NPDisk::DEVICE_TYPE_UNKNOWN;
             if (PDiskCtx && PDiskCtx->Dsk) {
                 mediaType = PDiskCtx->Dsk->TrueMediaType;
+                WriteSpeedBps = PDiskCtx->Dsk->WriteSpeedBps;
             }
             if (mediaType == NPDisk::DEVICE_TYPE_UNKNOWN) {
                 mediaType = VCfg->BaseInfo.DeviceType;
@@ -304,8 +303,7 @@ namespace NKikimr {
             if (!IsActive()) {
                 return 1000;
             }
-            ui64 deviceSpeed = (ui64)VCfg->ThrottlingDeviceSpeed;
-            double rate = (double)CurrentSpeedLimit / deviceSpeed;
+            double rate = (double)CurrentSpeedLimit / WriteSpeedBps;
             return rate * 1000;
         }
 
@@ -360,7 +358,7 @@ namespace NKikimr {
             if (!IsActive()) {
                 CurrentTime = {};
                 AvailableBytes = 0;
-                CurrentSpeedLimit = (ui64)VCfg->ThrottlingDeviceSpeed;
+                CurrentSpeedLimit = WriteSpeedBps;
             } else {
                 if (!prevActive) {
                     CurrentTime = now;
@@ -378,8 +376,7 @@ namespace NKikimr {
             }
             auto us = (now - CurrentTime).MicroSeconds();
             AvailableBytes += CurrentSpeedLimit * us / 1000000;
-            ui64 deviceSpeed = (ui64)VCfg->ThrottlingDeviceSpeed;
-            AvailableBytes = std::min(AvailableBytes, deviceSpeed);
+            AvailableBytes = std::min(AvailableBytes, WriteSpeedBps);
             CurrentTime = now;
         }
     };

ydb/core/protos/config.proto

@@ -1388,11 +1388,7 @@ message TImmediateControlsConfig {
             MaxValue: 50,
             DefaultValue: 10 }];
 
-        optional uint64 ThrottlingDeviceSpeed = 14 [(ControlOptions) = {
-            Description: "Maximum allowed speed when throttling is active",
-            MinValue: 1048576,
-            MaxValue: 10737418240,
-            DefaultValue: 52428800 }];
+        reserved 14;
         optional uint64 ThrottlingDryRun = 26 [(ControlOptions) = {
             Description: "0 - working mode, 1 - dry run mode",
             MinValue: 0,