Disentangle SS operation traits (#11972)

Author: Enjection

ydb/core/tx/schemeshard/olap/operations/create_store.cpp

@@ -1,6 +1,7 @@
 #include <ydb/core/tx/schemeshard/schemeshard__operation_part.h>
 #include <ydb/core/tx/schemeshard/schemeshard__operation_common.h>
 #include <ydb/core/tx/schemeshard/schemeshard_impl.h>
+#include <ydb/core/tx/schemeshard/schemeshard__op_traits.h>
 
 #include <ydb/core/base/subdomain.h>
 #include <ydb/core/scheme/scheme_types_proto.h>
@@ -527,6 +528,30 @@ class TCreateOlapStore: public TSubOperation {
 
 namespace NKikimr::NSchemeShard {
 
+using TTag = TSchemeTxTraits<NKikimrSchemeOp::EOperationType::ESchemeOpCreateColumnStore>;
+
+namespace NOperation {
+
+template <>
+std::optional<TString> GetTargetName<TTag>(
+    TTag,
+    const TTxTransaction& tx)
+{
+    return tx.GetCreateColumnStore().GetName();
+}
+
+template <>
+bool SetName<TTag>(
+    TTag,
+    TTxTransaction& tx,
+    const TString& name)
+{
+    tx.MutableCreateColumnStore()->SetName(name);
+    return true;
+}
+
+} // namespace NOperation
+
 ISubOperation::TPtr CreateNewOlapStore(TOperationId id, const TTxTransaction& tx) {
     return MakeSubOperation<TCreateOlapStore>(id, tx);
 }

ydb/core/tx/schemeshard/olap/operations/create_table.cpp

@@ -1,6 +1,7 @@
 #include <ydb/core/tx/schemeshard/schemeshard__operation_part.h>
 #include <ydb/core/tx/schemeshard/schemeshard__operation_common.h>
 #include <ydb/core/tx/schemeshard/schemeshard_impl.h>
+#include <ydb/core/tx/schemeshard/schemeshard__op_traits.h>
 
 #include <ydb/core/base/subdomain.h>
 #include <ydb/core/tx/columnshard/columnshard.h>
@@ -882,6 +883,30 @@ class TCreateColumnTable: public TSubOperation {
 
 }
 
+using TTag = TSchemeTxTraits<NKikimrSchemeOp::EOperationType::ESchemeOpCreateColumnTable>;
+
+namespace NOperation {
+
+template <>
+std::optional<TString> GetTargetName<TTag>(
+    TTag,
+    const TTxTransaction& tx)
+{
+    return tx.GetCreateColumnTable().GetName();
+}
+
+template <>
+bool SetName<TTag>(
+    TTag,
+    TTxTransaction& tx,
+    const TString& name)
+{
+    tx.MutableCreateColumnTable()->SetName(name);
+    return true;
+}
+
+} // namespace NOperation
+
 ISubOperation::TPtr CreateNewColumnTable(TOperationId id, const TTxTransaction& tx) {
     return MakeSubOperation<TCreateColumnTable>(id, tx);
 }

ydb/core/tx/schemeshard/schemeshard__backup_collection_common.cpp

@@ -1,8 +1,8 @@
 #include "schemeshard__backup_collection_common.h"
 
-namespace NKikimr::NSchemeShard {
+namespace NKikimr::NSchemeShard::NBackup {
 
-std::optional<TBackupCollectionPaths> ResolveBackupCollectionPaths(
+std::optional<NBackup::TBackupCollectionPaths> ResolveBackupCollectionPaths(
     const TString& rootPathStr,
     const TString& name,
     bool validateFeatureFlag,
@@ -74,7 +74,60 @@ std::optional<TBackupCollectionPaths> ResolveBackupCollectionPaths(
         return std::nullopt;
     }
 
-    return TBackupCollectionPaths{rootPath, dstPath};
+    return NBackup::TBackupCollectionPaths{rootPath, dstPath};
 }
 
-}  // namespace NKikimr::NSchemeShard
+std::optional<THashMap<TString, THashSet<TString>>> GetRequiredPaths(
+    const TTxTransaction& tx,
+    const TString& targetDir,
+    const TString& targetName,
+    const TOperationContext& context)
+{
+    THashMap<TString, THashSet<TString>> paths;
+    const TString& targetPath = JoinPath({tx.GetWorkingDir(), targetName});
+
+    const TPath& bcPath = TPath::Resolve(targetPath, context.SS);
+    {
+        auto checks = bcPath.Check();
+        checks
+            .NotEmpty()
+            .NotUnderDomainUpgrade()
+            .IsAtLocalSchemeShard()
+            .IsResolved()
+            .NotUnderDeleting()
+            .NotUnderOperation()
+            .IsBackupCollection();
+
+        if (!checks) {
+            return {};
+        }
+    }
+
+    Y_ABORT_UNLESS(context.SS->BackupCollections.contains(bcPath->PathId));
+    const auto& bc = context.SS->BackupCollections[bcPath->PathId];
+
+    auto& collectionPaths = paths[targetPath];
+    collectionPaths.emplace(targetDir);
+
+    for (const auto& item : bc->Description.GetExplicitEntryList().GetEntries()) {
+        std::pair<TString, TString> paths;
+        TString err;
+        if (!TrySplitPathByDb(item.GetPath(), tx.GetWorkingDir(), paths, err)) {
+            return {};
+        }
+
+        auto pathPieces = SplitPath(paths.second);
+        if (pathPieces.size() > 1) {
+            auto parent = ExtractParent(paths.second);
+            collectionPaths.emplace(JoinPath({targetDir, TString(parent)}));
+        }
+    }
+
+    return paths;
+}
+
+TString ToX509String(const TInstant& datetime) {
+    return datetime.FormatLocalTime("%Y%m%d%H%M%SZ");
+}
+
+}  // namespace NKikimr::NSchemeShard::NBackup

ydb/core/tx/schemeshard/schemeshard__backup_collection_common.h

@@ -7,7 +7,7 @@
 
 #include <optional>
 
-namespace NKikimr::NSchemeShard {
+namespace NKikimr::NSchemeShard::NBackup {
 
 struct TBackupCollectionPaths {
     TPath RootPath;
@@ -22,4 +22,12 @@ std::optional<TBackupCollectionPaths> ResolveBackupCollectionPaths(
     THolder<TProposeResponse>& result,
     bool enforceBackupCollectionsDirExists = true);
 
-}  // namespace NKikimr::NSchemeShard
+std::optional<THashMap<TString, THashSet<TString>>> GetRequiredPaths(
+    const TTxTransaction& tx,
+    const TString& targetDir,
+    const TString& targetName,
+    const TOperationContext& context);
+
+TString ToX509String(const TInstant& datetime);
+
+}  // namespace NKikimr::NSchemeShard::NBackup