Removed aborts in service initialization (#1652)

Author: domwst

ydb/core/driver_lib/run/kikimr_services_initializers.cpp

@@ -832,13 +832,19 @@ void TBasicServicesInitializer::InitializeServices(NActors::TActorSystemSetup* s
         std::unique_ptr<NWilson::IGrpcSigner> grpcSigner;
         if (tracing_backend.HasAuthConfig() && Factories && Factories->WilsonGrpcSignerFactory) {
             grpcSigner = Factories->WilsonGrpcSignerFactory(tracing_backend.GetAuthConfig());
+            if (!grpcSigner) {
+                Cerr << "Failed to initialize wilson grpc signer due to misconfiguration. Config provided: "
+                        << tracing_backend.GetAuthConfig().DebugString() << Endl;
+            }
         }
         NActors::IActor* wilsonUploader = nullptr;
         switch (tracing_backend.GetBackendCase()) {
             case NKikimrConfig::TTracingConfig::TBackendConfig::BackendCase::kOpentelemetry: {
                 const auto& opentelemetry = tracing_backend.GetOpentelemetry();
-                Y_ABORT_UNLESS(opentelemetry.HasCollectorUrl() && opentelemetry.HasServiceName(),
-                               "Both collector_url and service_name should be present in opentelemetry backedn config");
+                if (!(opentelemetry.HasCollectorUrl() && opentelemetry.HasServiceName())) {
+                    Cerr << "Both collector_url and service_name should be present in opentelemetry backend config" << Endl;
+                    break;
+                }
                 wilsonUploader = NWilson::WilsonUploaderParams {
                     .CollectorUrl = opentelemetry.GetCollectorUrl(),
                     .ServiceName = opentelemetry.GetServiceName(),
@@ -848,7 +854,7 @@ void TBasicServicesInitializer::InitializeServices(NActors::TActorSystemSetup* s
             }
 
             case NKikimrConfig::TTracingConfig::TBackendConfig::BackendCase::BACKEND_NOT_SET: {
-                Y_ABORT_UNLESS(false, "No backend option was provided in backend config");
+                Cerr << "No backend option was provided in tracing config" << Endl;
                 break;
             }
         }

ydb/core/tx/datashard/export_common.h

@@ -3,6 +3,7 @@
 #include "datashard_user_table.h"
 
 #include <ydb/core/protos/flat_scheme_op.pb.h>
+#include <ydb/library/actors/core/log.h>
 
 #include <util/generic/map.h>
 #include <util/generic/maybe.h>

ydb/library/actors/wilson/wilson_uploader.cpp

@@ -65,13 +65,20 @@ namespace NWilson {
             static constexpr char ActorName[] = "WILSON_UPLOADER_ACTOR";
 
             void Bootstrap() {
-                Become(&TThis::StateFunc);
+                Become(&TThis::StateWork);
 
                 TStringBuf scheme;
                 TStringBuf host;
                 ui16 port;
-                GetSchemeHostAndPort(CollectorUrl, scheme, host, port);
-                Y_ABORT_UNLESS(scheme == "grpc://" || scheme == "grpcs://", "Only grpc and grpcs schemes are supported for traces collector");
+                if (!TryGetSchemeHostAndPort(CollectorUrl, scheme, host, port)) {
+                    LOG_ERROR_S(*TlsActivationContext, WILSON_SERVICE_ID, "Failed to parse collector url (" << CollectorUrl << " was provided). Wilson wouldn't work");
+                    Become(&TThis::StateBroken);
+                    return;
+                } else if (scheme != "grpc://" && scheme != "grpcs://") {
+                    LOG_ERROR_S(*TlsActivationContext, WILSON_SERVICE_ID, "Wrong scheme provided: " << scheme << " (only grpc:// and grpcs:// are supported). Wilson wouldn't work");
+                    Become(&TThis::StateBroken);
+                    return;
+                }
                 Channel = grpc::CreateChannel(TStringBuilder() << host << ":" << port,
                                               scheme == "grpcs://" ? grpc::SslCredentials({}) : grpc::InsecureChannelCredentials());
                 Stub = NServiceProto::TraceService::NewStub(Channel);
@@ -189,10 +196,14 @@ namespace NWilson {
                 TryToSend();
             }
 
-            STRICT_STFUNC(StateFunc,
+            STRICT_STFUNC(StateWork,
                 hFunc(TEvWilson, Handle);
                 cFunc(TEvents::TSystem::Wakeup, HandleWakeup);
             );
+
+            STRICT_STFUNC(StateBroken,
+                IgnoreFunc(TEvWilson);
+            );
         };
 
     } // anonymous