Skip to content

Commit c837165

Browse files
authored
Merge 99f7603 into 0b3e86d
2 parents 0b3e86d + 99f7603 commit c837165

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

ydb/core/cms/cms_ut.cpp

+9-9
Original file line numberDiff line numberDiff line change
@@ -1810,7 +1810,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
18101810

18111811
Y_UNIT_TEST(EmergencyDuringRollingRestart)
18121812
{
1813-
TCmsTestEnv env(TTestEnvOpts(8).WithEnableCMSRequestPriorities());
1813+
TCmsTestEnv env(8);
18141814

18151815
// Start rolling restart
18161816
auto rollingRestart = env.CheckPermissionRequest
@@ -1839,7 +1839,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
18391839

18401840
Y_UNIT_TEST(ScheduledEmergencyDuringRollingRestart)
18411841
{
1842-
TCmsTestEnv env(TTestEnvOpts(8).WithEnableCMSRequestPriorities());
1842+
TCmsTestEnv env(8);
18431843

18441844
// Start rolling restart
18451845
auto rollingRestart = env.CheckPermissionRequest
@@ -1871,7 +1871,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
18711871

18721872
Y_UNIT_TEST(WalleRequestDuringRollingRestart)
18731873
{
1874-
TCmsTestEnv env(TTestEnvOpts(8).WithEnableCMSRequestPriorities());
1874+
TCmsTestEnv env(8);
18751875

18761876
// Start rolling restart
18771877
auto rollingRestart = env.CheckPermissionRequest
@@ -1899,7 +1899,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
18991899

19001900
Y_UNIT_TEST(ScheduledWalleRequestDuringRollingRestart)
19011901
{
1902-
TCmsTestEnv env(TTestEnvOpts(8).WithEnableCMSRequestPriorities());
1902+
TCmsTestEnv env(8);
19031903

19041904
// Start rolling restart
19051905
auto rollingRestart = env.CheckPermissionRequest
@@ -1930,7 +1930,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
19301930

19311931
Y_UNIT_TEST(EnableCMSRequestPrioritiesFeatureFlag)
19321932
{
1933-
TCmsTestEnv env(8);
1933+
TCmsTestEnv env(TTestEnvOpts(8).WithoutEnableCMSRequestPriorities());
19341934
// Start rolling restart with specified priority
19351935
auto rollingRestart = env.CheckPermissionRequest
19361936
("user", true, false, true, true, -80, TStatus::WRONG_REQUEST,
@@ -1943,7 +1943,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
19431943

19441944
Y_UNIT_TEST(SamePriorityRequest)
19451945
{
1946-
TCmsTestEnv env(TTestEnvOpts(8).WithEnableCMSRequestPriorities());
1946+
TCmsTestEnv env(8);
19471947

19481948
// Start rolling restart
19491949
auto rollingRestart = env.CheckPermissionRequest
@@ -1973,7 +1973,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
19731973

19741974
Y_UNIT_TEST(SamePriorityRequest2)
19751975
{
1976-
TCmsTestEnv env(TTestEnvOpts(8).WithEnableCMSRequestPriorities());
1976+
TCmsTestEnv env(8);
19771977

19781978
// Start rolling restart
19791979
auto rollingRestart = env.CheckPermissionRequest
@@ -2003,7 +2003,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
20032003

20042004
Y_UNIT_TEST(PriorityRange)
20052005
{
2006-
TCmsTestEnv env(TTestEnvOpts(8).WithEnableCMSRequestPriorities());
2006+
TCmsTestEnv env(8);
20072007

20082008
const TString expectedReason = "Priority value is out of range";
20092009

@@ -2024,7 +2024,7 @@ Y_UNIT_TEST_SUITE(TCmsTest) {
20242024

20252025
Y_UNIT_TEST(WalleTasksDifferentPriorities)
20262026
{
2027-
TCmsTestEnv env(TTestEnvOpts(8).WithEnableCMSRequestPriorities());
2027+
TCmsTestEnv env(8);
20282028

20292029
// Without node limits
20302030
NKikimrCms::TCmsConfig config;

ydb/core/cms/cms_ut_common.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ struct TTestEnvOpts {
107107
, UseMirror3dcErasure(false)
108108
, AdvanceCurrentTime(false)
109109
, EnableSentinel(false)
110-
, EnableCMSRequestPriorities(false)
110+
, EnableCMSRequestPriorities(true)
111111
, EnableSingleCompositeActionGroup(true)
112112
{
113113
}
@@ -122,8 +122,8 @@ struct TTestEnvOpts {
122122
return *this;
123123
}
124124

125-
TTestEnvOpts& WithEnableCMSRequestPriorities() {
126-
EnableCMSRequestPriorities = true;
125+
TTestEnvOpts& WithoutEnableCMSRequestPriorities() {
126+
EnableCMSRequestPriorities = false;
127127
return *this;
128128
}
129129
};

ydb/core/protos/feature_flags.proto

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ message TFeatureFlags {
133133
optional bool EnableAccessServiceBulkAuthorization = 114 [default = false];
134134
optional bool EnableAddColumsWithDefaults = 115 [ default = false];
135135
optional bool EnableReplaceIfExistsForExternalEntities = 116 [ default = false];
136-
optional bool EnableCMSRequestPriorities = 117 [default = false];
136+
optional bool EnableCMSRequestPriorities = 117 [default = true];
137137
optional bool EnableKeyvalueLogBatching = 118 [default = false];
138138
optional bool EnableLocalDBFlatIndex = 119 [default = true];
139139
optional bool ExtendedVDiskCounters = 120 [default = true];

0 commit comments

Comments
 (0)